Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code to 1.88.1 #6754

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Update Code to 1.88.1 #6754

merged 2 commits into from
Apr 15, 2024

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Apr 11, 2024

@benz0li benz0li requested a review from a team as a code owner April 11, 2024 17:46
@benz0li
Copy link
Contributor Author

benz0li commented Apr 12, 2024

@code-asher Please re-run. My local build was successful.

@code-asher
Copy link
Member

code-asher commented Apr 15, 2024

Weird, I ran it a couple times but it keeps getting ENOENT.

Oh...I think I know why. Something about node-gyp being removed from npm. We updated Node to 18.18.2, but it did not trigger a rebuild of VS Code because of the cache (which itself is a bug I will have to fix actually this is fine because the built JavaScript is not dependent on the version of Node, it is only the release flows that matter and they do rebuild), so it is only now causing an issue.

Might work to install node-gyp globally, let me test it later today and see.

Edit: Although, not sure why the release flow worked and the build flow does not. They both use the same version of Node, and they both install @parcel/watcher.

@code-asher code-asher merged commit 9a28bc2 into coder:main Apr 15, 2024
9 checks passed
@benz0li
Copy link
Contributor Author

benz0li commented Apr 16, 2024

@code-asher What about the failed e2e tests?: https://github.com/coder/code-server/actions/runs/8698237868

@code-asher
Copy link
Member

code-asher commented Apr 16, 2024

Ah yeah I was worried about that, looks like the Express update broke something.

Not to worry though, the commit that was actually released is 9a28bc2 which did pass, that commit was just for updating the changelog and Helm chart afterward.

I will have to look into or revert the Express update though.

@code-asher
Copy link
Member

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants