-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify & Refactor Code 🚀 #37
Conversation
Hey @yezz123 Thanks for creating this PR. Sorry that I was not able to review until now, there were multiple backlogged features/improvements that needed to be put ASAP. I think due to some of the recent changes, this PR has some conflicts that would likely be solved by a re-base. Once you re-base let me know and we can kick off the tests. |
Hello @codemation i just fix the rebase issue i guess you can run the test suite now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yezz123 Nice additions with formatting and precommit. Very important for enabling future contributors.
Looks like all tests are passing, so I will merge this and quickly verify GUI functionality before release.
Hello, @codemation I just fix multiple things in this project for example:
We could discuss all changes if you want 🚀