Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify & Refactor Code 🚀 #37

Merged
merged 13 commits into from
Nov 30, 2021
Merged

Minify & Refactor Code 🚀 #37

merged 13 commits into from
Nov 30, 2021

Conversation

yezz123
Copy link
Contributor

@yezz123 yezz123 commented Nov 23, 2021

Hello, @codemation I just fix multiple things in this project for example:

  • Merge both of the workflows in one, and add a simple check for linting.
  • Add a global linting and formatting configuration.
  • Refactor multiple parts of code & Fix Multiple PEPs code.
  • Add More Classifiers to the Setup file.
  • And More changes.
    We could discuss all changes if you want 🚀

@codemation
Copy link
Owner

Hey @yezz123

Thanks for creating this PR. Sorry that I was not able to review until now, there were multiple backlogged features/improvements that needed to be put ASAP. I think due to some of the recent changes, this PR has some conflicts that would likely be solved by a re-base. Once you re-base let me know and we can kick off the tests.

@yezz123
Copy link
Contributor Author

yezz123 commented Nov 30, 2021

Hello @codemation i just fix the rebase issue i guess you can run the test suite now

Copy link
Owner

@codemation codemation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yezz123 Nice additions with formatting and precommit. Very important for enabling future contributors.

Looks like all tests are passing, so I will merge this and quickly verify GUI functionality before release.

@codemation codemation merged commit 543526c into codemation:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants