Avoid NPE in AspectJCompilerTest on AspectJ 1.9.8+ #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `aspectj.version` from 1.9.7.M3 to 1.9.9.1. Updates `aspectjrt` from 1.9.7.M3 to 1.9.9.1 - [Release notes](https://github.com/eclipse/org.aspectj/releases) - [Commits](https://github.com/eclipse/org.aspectj/commits) Updates `aspectjtools` from 1.9.7.M3 to 1.9.9.1 - [Release notes](https://github.com/eclipse/org.aspectj/releases) - [Commits](https://github.com/eclipse/org.aspectj/commits) --- updated-dependencies: - dependency-name: org.aspectj:aspectjrt dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.aspectj:aspectjtools dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Due to changed Eclipse Compiler (JDT Core) upstream of AJC, we need to call 'buildArgParser.populateBuildConfig(..)' in order to avoid an NPE when AjBuildConfig.getCheckedClasspaths() is called later during compilation. Only the unit test (which is not really a unit test) is affected by this problem, because it compiles in-process. The 'aspectj-compiler' IT was still passing before this change.
|
@slachiewicz, the separate PR looks better than the one which tried to piggy-back on #227. The build is green, too. 🙂 |
slachiewicz
approved these changes
Jun 25, 2022
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changed Eclipse Compiler (JDT Core) upstream of AJC, we need to call
buildArgParser.populateBuildConfig(..)in order to avoid an NPE whenAjBuildConfig.getCheckedClasspaths()is called later during compilation.Only the unit test (which is not really a unit test) is affected by this problem, because it compiles in-process. The
aspectj-compilerIT was still passing before this change.Supersedes #227. Somehow, PRs on top of other PRs are not working as expected.
Closes eclipse-aspectj/aspectj#169.