Add new showLint compiler configuration #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
requested changes
Apr 25, 2021
...compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java
Outdated
Show resolved
Hide resolved
...rs/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java
Outdated
Show resolved
Hide resolved
|
thanks @bondolo for your contribution. I just added some nit comments :) but sounds a nice enhancement |
Adds the ability to configure additional non-default compiler warnings and lint. To be used for the javac -Xlint or similar features of the ECJ compiler.
olamy
reviewed
Apr 28, 2021
remove added whitespace.
olamy
approved these changes
Apr 28, 2021
pzygielo
reviewed
Apr 29, 2021
| return warnings; | ||
| } | ||
|
|
||
| public void setShowLint( String warnings ) |
There was a problem hiding this comment.
I find this lack of symmetry between get/set/field disturbing.
Also - other setShow*s seem to accept boolean.
There was a problem hiding this comment.
@pzygielo ah yes I agree It's confusing I will change that
There was a problem hiding this comment.
The problem was that there was an existing showWarnings() flag. The intention was that the warnings flag would still control whether lint would be shown to avoid the weird corner case where warnings were disabled and lint was configured.
warnings enabled : show errors, warnings and "lint"
warnings disabled : show errors only.
olamy
added a commit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: olivier lamy <olamy@apache.org>
olamy
added a commit
that referenced
this pull request
May 2, 2021
Signed-off-by: olivier lamy <olamy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure additional non-default compiler warnings and lint. To be used for the javac -Xlint or similar features of the ECJ compiler. The option will be added to the maven-java-compiler plugin (which depends upon plexus-compiler)