Fix CircleCI configuration #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHawley
force-pushed
the
fixes_20221216_circle_ci_config
branch
from
e846427
to
7b384f9
Compare
CircleCI sent me an email indicating that the config settings for this repo were set to use a deprecated image (Ubuntu 14.04) because we didn't specify the image to use. The image option is required, per their docs; set it as recommended.
BrianHawley
force-pushed
the
fixes_20221216_circle_ci_config
branch
from
7b384f9
to
5e6364a
Compare
|
@fede-moya or @filipesperandio could you review and merge? This should also be able to be cherry-picked to other new channels, though they really should be based on channel/beta anyways so that shouldn't be a problem. The particular setting only affects the process of creating a new version of the engine image in docker, and only affects the host process that is building the image. It doesn't affect the built image itself, which is based on Dockerfile instead of this config. |
|
@fede-moya this change is still needed. Could you review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI sent me an email indicating that the config settings for this repo were set to use a deprecated image (Ubuntu 14.04) because we didn't specify the image to use.
The image option is required, per their docs; set it as recommended.