-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chat channel API #69
base: master
Are you sure you want to change the base?
Conversation
Note: formatting is weird for some reason. I'll have to update it. |
I've fixed the remaining showstoppers for the implementation. The gist of changes is:
I have written a small script that can be used to test the new functionality: bc-channels.as. It's also an example of the expected usage of the API. |
Very nice! I will do my best to review this properly soon, but I'm very busy recently so no guarantees. Feel free to ping me in a week if I haven't checked it out yet. Do you have some screenshots of what this looks like in-game? |
Hey, it's been a fair bit more than a week now, so just a reminder for you to check this out when you can. Thanks! |
Gently bumping this PR to get a review, I'm looking to use this API soon. Still looking at this @codecat? |
Draft implementation of #65. Quite a lot of changes to break out the initial assumption of BC that only one message destination exists. The draft UI uses tab-like buttons to switch between different chat channels. For the most part, each channel should be isolated, which means some relevant structures have been moved to a
ChatChannel
class.This is not completely ready, but I'm submitting it at this stage to get a review on what's been done so far. Implementation is mostly done apart from correctly handling Listeners.