Demo PR #33
Demo PR #33
Conversation
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
LGTM, just one thing.
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Can you add a method comment?
👀 @samatcodeapprove it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Will do!
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Have you tested this?
👀 @samatcodeapprove it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Yes I have!
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Have you tested this?
👀 @samatcodeapprove it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Yes I have!
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Have you tested this?
👀 @samatcodeapprove it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Yes I have!
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
Have you tested this?
👀 @samatcodeapprove it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
I have!
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: demo/file1.ts:
> Line 1
export function generateRandomNumber(min: number, max: number): number {
This needs to change
In: demo/file1.ts:
> Line 9
constructor(name: string, age: number) {
I love this!
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
Automated comment from CodeApprove ➜👀 @samatcodeapprove it's your turn, please take a look |
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (2 unresolved comments)
Approval will be granted automatically when all comments are resolved
This looks great, just one thing!
In: Discussion
This is a discussion on the whole PR
In: demo/file1.ts:
> Line 5
export class Person {
Could this have a comment?
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
This looks great
👀 @samatcodeapprove it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Thanks for the review!
In: Discussion
Thanks for discussing
In: demo/file1.ts:
> Line 5
export class Person {
Actually comments are impossible
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
alicethecoder
dismissed stale reviews from themself
Review approved on CodeApprove
Automated comment from CodeApprove ➜⏳ @alicethecoder please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (2 unresolved comments)
Approval will be granted automatically when all comments are resolved
I think this is close to done.
In: demo/file1.ts:
> Line 5
export class Person {
Can you add a comment to this class?
In: demo/utils.ts:
> Line 5
export function multiply(num1: number, num2: number): number {
This looks great.
👀 @samatcodeapprove it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Thanks!
In: Discussion
Thanks for letting me know!
In: demo/file1.ts:
> Line 5
export class Person {
I'd like to do that later, I'm recording a demo now.
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Automated comment from CodeApprove ➜👀 @alicethecoder it's your turn, please take a look |
In this PR I've added some new files:
file1.tsfile2.tsI've also modified this file:
utils.ts