Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-scripts from 3.4.0 to 3.4.1 in /client #211

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Mar 21, 2020

Bumps react-scripts from 3.4.0 to 3.4.1.

Changelog

Sourced from react-scripts's changelog.

3.4.1 (2020-03-20)

v3.4.1 is a maintenance release that includes minor bug fixes and documentation updates including upgrading Babel to fix a bug in the 7.8 release line. This release also brings support for TypeScript 3.8.

🐛 Bug Fix

  • react-scripts
  • babel-preset-react-app
  • cra-template, eslint-config-react-app, react-scripts
    • #7790 Widen eslint-config-react-app peer dependency versions (@lukyth)

💅 Enhancement

  • cra-template-typescript, cra-template
  • react-scripts

📝 Documentation

  • Other
    • #8515 Fix proxying API request docs (@hjr3)
    • #8561 Indicate that the file structure is the template's (@Vinnl)
  • react-scripts

🔨 Underlying Tools

  • babel-preset-react-app, create-react-app, react-dev-utils, react-error-overlay, react-scripts
  • react-scripts

Committers: 9

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file react labels Mar 21, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch 2 times, most recently from 352a052 to 873493c Compare April 22, 2020 13:22
@tudoramariei
Copy link
Member

Something doesn't seem alright with this PR
After starting the docker, the client stays on for a while but then exists. I'd appreciate if someone can have another look over this one and tell me if you have the same behaviour.

seismic-risc-client | Starting the development server...
seismic-risc-client | 
seismic-risc-client exited with code 0

@tudoramariei tudoramariei changed the base branch from master to develop April 22, 2020 20:14
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from 873493c to 072981d Compare April 23, 2020 10:38
@vercel
Copy link

vercel bot commented Apr 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/seismic-risc/4r9ms6w0z
✅ Preview: https://seismic-risc-git-dependabot-npmandyarnclientmasterreac-2035c7.code4romania.now.sh

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from 072981d to f10dcab Compare April 23, 2020 10:47
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from f10dcab to dde9d9b Compare April 23, 2020 11:00
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from dde9d9b to d974776 Compare April 23, 2020 11:10
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from d974776 to da8aa8f Compare April 23, 2020 12:43
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from da8aa8f to 8d36c0d Compare April 23, 2020 12:47
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from 8d36c0d to 1238aab Compare May 22, 2020 12:31
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from 1238aab to f035232 Compare May 22, 2020 12:57
@tudoramariei tudoramariei added the invalid This doesn't seem right label May 22, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch from f035232 to 6199ca1 Compare May 22, 2020 13:10
@tudoramariei
Copy link
Member

Seems like the newest react-scripts has some issues with docker
facebook/create-react-app#8688

@tudoramariei
Copy link
Member

@dependabot ignore this minor version

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you about version 3.4.x again, unless you re-open this PR or update to a 3.4.x release yourself.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/client/master/react-scripts-3.4.1 branch May 22, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant