Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the store field in codalab worksheet UI to display real bundle location. #4593

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HidyHan
Copy link
Contributor

@HidyHan HidyHan commented Apr 23, 2024

Reasons for making this change

Previously the UI uses metadata.store, which is a parameter user optionally specifies when a bundle is created. However, this is not necessarily where the bundle is ultimately stored and can be empty, which is confusing.
Screenshot from 2024-04-23 11-56-38

Related issues

Screenshots

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@HidyHan HidyHan requested a review from wwwjn April 23, 2024 18:59
Copy link
Contributor

@wwwjn wwwjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for identifying the problem here

@wwwjn
Copy link
Contributor

wwwjn commented Apr 23, 2024

Pls address the failing CI checks first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants