Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#issue-680 and #issue-681 #682

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

krazyeom
Copy link
Contributor

@krazyeom krazyeom commented Apr 6, 2014

fixed scale bug #issue-680

issue-681 support a keyboard for mac

@slembcke
Copy link
Contributor

I'll close #680 and #681 now since they are handled here.

@Birkemose any thoughts on the CCResponder changes?

@vlidholt It looks like you commented out the retina line so that one would have to enable retina explicitly. I vaguely remember discussing that a couple months ago. It seems related to #632.

@andykorth
Copy link
Contributor

Issue 680, the scale bug seems to be fixed in develop-v4 basically as described here.

I'm going to take a look at Mac keyboard support using this commit. Thanks!

@LearnCocos2D
Copy link
Contributor

What's the status of #681 keyboard support for Mac? Currently documenting input events, just want to know if I should delay documenting keyboard events if it gets integrated in CCResponder soon.

Let me know if there are any obvious changes that need to be applied to the pull request, maybe I'll try documenting it as far as I can without actually being able to test the code.

Am I correct assuming that NSEvent will have to be converted to a CCKeyEvent object?

@andykorth
Copy link
Contributor

Basic Mac input support was added in #1191 and #1174. These two commits were worked into #1174, (since they were merged quite a while after the original contribution, there were some conflicts cleaned up in those branches). Github didn't really seem to pick up on the cherry-picking anywhere I guess.

So the status is that basic keyboard support works. There's support for nodes receiving keyboard and mouse up/down events. There's currently no way to check something like iskeyDown: in your update loop. For now that can be pretty easily implemented in game code. It would be great to add that by v4, but I'm not sure where it falls priority-wise.

I don't think the stuff that's currently in there is likely to move or change, so it can be documented. The only thing that might change is the 'other' mouse button: #1234

@LearnCocos2D
Copy link
Contributor

Ah thanks, I could not find the slightest reference to "key" events in CCResponder or CCResponderManager in v3.4.1. But it's there in develop (v3.4.3). I didn't expect this to be a very recent addition.

@andykorth
Copy link
Contributor

Oh sorry, yeah, the changes we did are in develop for v4.

There was no mac keyboard support in any v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants