Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: fix clippy warning #68

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fs: fix clippy warning #68

merged 1 commit into from
Aug 8, 2023

Conversation

00xc
Copy link
Member

@00xc 00xc commented Jul 21, 2023

Fix a new clippy warning that comes up with the latest nightly toolchain:

warning: this argument is a mutable reference, but not used mutably
   --> src/fs/filesystem.rs:265:36
    |
265 | pub fn write(fh: &FileHandle, buf: &mut [u8]) -> Result<usize, SvsmError> {
    |                                    ^^^^^^^^^ help: consider changing to: `&[u8]`
    |
    = warning: changing this function will impact semver compatibility
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
    = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default

Fix a new clippy warning that comes up with the latest nightly
toolchain:

warning: this argument is a mutable reference, but not used mutably
   --> src/fs/filesystem.rs:265:36
    |
265 | pub fn write(fh: &FileHandle, buf: &mut [u8]) -> Result<usize, SvsmError> {
    |                                    ^^^^^^^^^ help: consider changing to: `&[u8]`
    |
    = warning: changing this function will impact semver compatibility
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
    = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default

Signed-off-by: Carlos López <carlos.lopez@suse.com>
Copy link
Collaborator

@roy-hopkins roy-hopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joergroedel joergroedel merged commit 2d1cf90 into coconut-svsm:main Aug 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants