copy edits of known limitations page #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sploiselle
force-pushed
the
known-limitations-copy-edit
branch
from
f9c54b4
to
dc5c74e
Compare
jseldess
approved these changes
May 12, 2017
known-limitations.md
Outdated
|
|
||
| ## `unique_rowid()` values in Javascript | ||
| ## `unique_rowid()` values in JavaScript |
There was a problem hiding this comment.
Turns out we should just remove this known limitation. See cockroachdb/cockroach#15721 (comment).
There was a problem hiding this comment.
Actually, the approach now is to remove this from known limitations and put it elsewhere. See that linked issue. Feel free to leave this for a follow-on PR, if you prefer, @sploiselle.
There was a problem hiding this comment.
👍 will leave for follow-up PR
known-limitations.md
Outdated
| - use the UTC time zone regardless of the time zone configured in the current session via [`SET TIME ZONE`](set-time-zone.html). | ||
| - have no default database regardless of the default database configured in the current session via [`SET DATABASE`](set-database.html). | ||
| - use the transaction timestamp for the `statement_timestamp()` function regardless of the time at which the `ALTER` statement was issued. | ||
| - Use the default [search path](sql-name-resolution.html#search-path) regardless of the search path configured in the current session via `SET SEARCH_PATH`. |
There was a problem hiding this comment.
I'd made these lower-case because each is a completion of the sentence started before the colon. I usually like to introduce a list with a complete clause but didn't have the time here. If you can find a way to do that, it'd be better. Otherwise, I'm fine with this change.
sploiselle
force-pushed
the
known-limitations-copy-edit
branch
from
dc5c74e
to
5ad6ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave it a twice-over. Doesn't look like I introduced many new typos.
This change is