job: add job profiler bundles to the job details page #105481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to statement bundles this change introduces the infrastructure to collect and read job profiler bundles. Right now, a job profiler bundle will only contain the latest DSP diagram for a job, but going forward this will give us a place to dump raw files such as: - cluster-wide job traces - cpu profiles - trace-driven aggregated stats - raw payload and progress protos Downloading this bundle will be exposed in a future patch in all of the places where statement bundles are today: - DBConsole - CLI shell - SQL shell This change introduces a builtin that constructs and writes the bundle for a job to the system.job_info table. It also introduces a new endpoint on the status server to read this constructed bundle. The next set of PRs will add the necessary components to allow downloading the bundle from the DBConsole. Informs: cockroachdb#105076 Release note: None
This change adds a new component to the `Profiler` tab of the job details page that supports collecting and viewing job profiler bundles. The component has a button to collect job profiler bundles. These bundles are then listed in a sorted table with the ability to download each bundle. The above operations are backed by the infrastructure added in cockroachdb#105384. Note, the `Profiler` tab is currently disabled for CC but this change allows for a future project to enable the collection of bundles through the CC console as well. Informs: cockroachdb#105076 Release note (ui change): collect and download job profiler bundles from the `Profiler` tab on the job details page.
|
This change is |
|
closing in favour of #106879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new component to the
Profilertabof the job details page that supports collecting and viewing
job profiler bundles. The component has a button to collect
job profiler bundles. These bundles are then listed in a sorted
table with the ability to download each bundle.
The above operations are backed by the infrastructure added
in #105384.
Note, the
Profilertab is currently disabled for CC but thischange allows for a future project to enable the collection of
bundles through the CC console as well.
Informs: #105076
Release note (ui change): collect and download job profiler
bundles from the
Profilertab on the job details page.