ansible: Move npm CA file back to env variable #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2024
Commit dbd7643 caused a regression: The `cafile` npmrc option *only* uses the given CA, while `$NODE_EXTRA_CA_CERTS` uses the given CA *in addition*. That broke fetching npm modules directly from github.com, which needs the system default CA lists.
|
I rolled this out, retried the two bots tests, and they succeed now (at least they are past |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit dbd7643 caused a regression: The
cafilenpmrc option only uses the given CA, while$NODE_EXTRA_CA_CERTSuses the given CA in addition. That broke fetching npm modules directly from github.com, which needs the system default CA lists.Blocks cockpit-project/bots#6148 and also cockpit-project/bots#6160. See the former for debugging notes.