tasks: Add cockpituous refs/heads/main mock API endpoint #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
job-runner needs that for cross-project testing [1]. A clean way would be to actually resolve "main" to a current SHA in the test, but as nothing actually cares, just rely on the `main` fallback for now -- nothing cares whether this is an actual SHA, as most things in git are happy with a "ref" -- and we don't use that to post statuses (and that would fail because the mock doesn't provide these paths). [1] cockpit-project/bots#6066
|
@allisonkarlitskaya If this is too smelly for you, I'm happy to put in the SHA resolution, but I'm more of a "build it only when needed" kind of guy 😁 |
2 tasks
From IRC this morning:
|
allisonkarlitskaya
approved these changes
Mar 12, 2024
| # for cross-project test; job-runner uses it to determine the clone SHA | ||
| '/repos/cockpit-project/cockpituous/git/refs/heads/main': { | ||
| # that fallback is strictly wrong, but good enough | ||
| 'object': {'sha': args.cockpituous_sha or "main"}, |
There was a problem hiding this comment.
I considered checking this for validity on receipt, but meh. If it works, it works. It's just mocking, after all.
I'm more bothered by the ad-hoc way in which we keep adding stuff here. I want git-serve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job-runner needs that for cross-project testing [1]. A clean way would be to actually resolve "main" to a current SHA in the test, but as nothing actually cares, just rely on the
mainfallback for now -- nothing cares whether this is an actual SHA, as most things in git are happy with a "ref" -- and we don't use that to post statuses (and that would fail because the mock doesn't provide these paths).[1] cockpit-project/bots#6066
This unblocks cockpit-project/bots#6066