unit-tests: Switch stdio to non-blocking after invoking Node.js #9484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefwalter
force-pushed
the
node-js-non-block-stdio
branch
from
e290d79
to
1625a3e
Compare
Node leaves stdio file descriptors in non-blocking mode when exiting. This has been reported, fixed, unfixed, ad nauseum. nodejs/node#14752 nodejs/node#17737 nodejs/node#20592 nodejs/node#21257 Should this become a problem in more places, we could add such a workaround elsewhere. But for now I'm limiting the ugliness to the unit-tests container, where we see this cause a lot of failures. Closes cockpit-project#9484
stefwalter
force-pushed
the
node-js-non-block-stdio
branch
from
1625a3e
to
d920c1c
Compare
|
Pushed a new set of containers. |
martinpitt
approved these changes
Jun 24, 2018
|
|
||
| assert "NODE_PATH" in os.environ | ||
| proc = subprocess.Popen([ os.environ["NODE_PATH"] ] + sys.argv[1:]) | ||
| proc.wait() |
There was a problem hiding this comment.
Fine like that, just FYI: ret = subprocess.call([...])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node leaves stdio file descriptors in non-blocking mode
when exiting. This has been reported, fixed, unfixed, ad nauseum.
nodejs/node#14752
nodejs/node#17737
nodejs/node#20592
nodejs/node#21257
Should this become a problem in more places, we could add such
a workaround elsewhere. But for now I'm limiting the ugliness to
the unit-tests container, where we see this cause a lot of failures.