Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: fix typos found by codespell #20830

Merged
merged 1 commit into from
Aug 2, 2024
Merged

pkg: fix typos found by codespell #20830

merged 1 commit into from
Aug 2, 2024

Conversation

jelly
Copy link
Member

@jelly jelly commented Aug 1, 2024

No description provided.

@jelly jelly requested a review from martinpitt August 1, 2024 12:57
martinpitt
martinpitt previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lots of failures, but presumably just flakes due to 3x affected. I do a round of retries.

@martinpitt
Copy link
Member

Also: yay. firewalld in c10s was finally fixed! https://artifacts.dev.testing-farm.io/ef643298-5d63-4237-b247-0bd64cae528c/

@jelly
Copy link
Member Author

jelly commented Aug 2, 2024

Thanks! Lots of failures, but presumably just flakes due to 3x affected. I do a round of retries.

Yup, was afraid of that

@martinpitt
Copy link
Member

@jelly This pixel failure is real: https://cockpit-logs.us-east-1.linodeobjects.com/pull-20830-defa473a-20240802-065308-fedora-40-storage/log.html

@martinpitt martinpitt dismissed their stale review August 2, 2024 07:10

needs pixel ref update

@jelly
Copy link
Member Author

jelly commented Aug 2, 2024

@jelly This pixel failure is real: https://cockpit-logs.us-east-1.linodeobjects.com/pull-20830-defa473a-20240802-065308-fedora-40-storage/log.html

A real fix!

@jelly
Copy link
Member Author

jelly commented Aug 2, 2024

To not let this rot, force pushed with pixel test fixes

@jelly jelly merged commit 22b8848 into cockpit-project:main Aug 2, 2024
77 of 79 checks passed
@jelly jelly deleted the codespell-fixes branch August 2, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @martinpitt