Another tsc run pass which found some invalid properties #20769
Conversation
|
especially fun |
yes! Nicely spotted! |
| @@ -123,7 +123,6 @@ export const PasswordFormFields = ({ | |||
| </button> | |||
| </Popover> | |||
| } | |||
| validated={error_password ? "warning" : "default"} | |||
There was a problem hiding this comment.
I wonder what the intention was here. This kinda looks like a variant field, except this component doesn't have one.
In any case, this doesn't make anything worse.
There was a problem hiding this comment.
The validated property normally goes into the input element inside of the FormGroup, like e.g. here in kdump. Firewall and lots of other places use that, too.
In this case it was meant to go into the TextInput className="check-passwords" below, but that already has it. So removing it here is correct.
|
Ugh, lots and lots of failures, but they all look unsystematic/flakes. Retrying once. |
| @@ -123,7 +123,6 @@ export const PasswordFormFields = ({ | |||
| </button> | |||
| </Popover> | |||
| } | |||
| validated={error_password ? "warning" : "default"} | |||
There was a problem hiding this comment.
The validated property normally goes into the input element inside of the FormGroup, like e.g. here in kdump. Firewall and lots of other places use that, too.
In this case it was meant to go into the TextInput className="check-passwords" below, but that already has it. So removing it here is correct.
| @@ -1455,7 +1455,7 @@ export function settings_applier(model, device, connection) { | |||
| } else if (device) { | |||
| return device.activate_with_settings(settings); | |||
| } else { | |||
| cockpit.warn("No way to apply settings", connection, settings); | |||
| console.warn("No way to apply settings", connection, settings); | |||
There was a problem hiding this comment.
This added line is not executed by any test.
No description provided.