Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加二维码,微信分享 #590

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zysam
Copy link
Contributor

@zysam zysam commented Nov 8, 2015

见到有社员想将文章分享到微信,于是增加功能。
add_sharetowechat

zysam and others added 6 commits November 7, 2015 17:16
Conflicts:
	Makefile
	middlewares/proxy.js
	package.json
	test/common/render_helper.test.js
	test/middlewares/limit.test.js
	test/middlewares/proxy.test.js
	views/sign/reset.html
Signed-off-by: zysam <expwind@gmail.com>
@alsotang
Copy link
Member

alsotang commented Nov 8, 2015

这件事情我倾向于交给浏览器插件来做,或者第三方。

下次提交 pr 之前,我们先 issue 里面讨论一下吧

@zysam
Copy link
Contributor Author

zysam commented Nov 9, 2015

开始好奇这个功能怎么实现。后来发现用微信扫一扫就可以跳转到网页,再利用微信的内置工具即可分享出来。所以只须 url 生成二维码即可。

1、我试过找第三方插件代码插入的方法,如jiathis。觉得太大题小作了。
2、原网页有QRCode库,直接就拿来用了,不敢添太多代码。
3、不好意思。 我刚看完github操作视频,就练手了,下次注意。

讨论是必要的,我觉得还是把代码和效果贴出来先,再考虑加不加这个功能。

@alsotang
Copy link
Member

alsotang commented Nov 9, 2015

这东西我做过。代码在 nodeclub 里面就有。
我们的个人设置页里面,就有二维码。手机 app 扫码就能登陆。

@zysam
Copy link
Contributor Author

zysam commented Nov 9, 2015

嗯。就是看设置页有二维码,才知道有二维码的库。话题页要不要这功能呢?
分享在移动端是一个算默认的功能吧,用移动端打开的网页都有分享。

PC网页如果不用借第三方工具,就是让移动端扫一扫可以打开网页,再分享。

当然这功能也不是刚需,也是最近社区的微信群多了,想随手用下。

不过,加上二维码,能提升逼格。个人建议。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants