Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COM.FLOW.FilePath #115

Closed
4 tasks done
WaldoFR opened this issue Jun 14, 2018 · 1 comment · Fixed by #156
Closed
4 tasks done

COM.FLOW.FilePath #115

WaldoFR opened this issue Jun 14, 2018 · 1 comment · Fixed by #156
Assignees
@brigittehuynh
Labels
enhancement shell
Milestone
Version 3.1.0-alp...

Comments

@WaldoFR
Copy link

WaldoFR commented Jun 14, 2018 •
edited by brigittehuynh
Loading

Implementation of the rule COM.FLOW.FilePath

Description

It is mandatory to use language's configuration file or call parameter or a variable to access a file.

Known problems

Wrong implementation

Description : The current implementation of the rule is getting it wrong. It's verifying if a file extension (considered as [\.][a-zA-Z][^\.]{0,5}) is involved in a variable assignation, after a redirection >, a cat, a rmor a more. (example : MODULE=example.ksh).

  • Fix status

State of the implementation

  • Violation raising
  • Localization
  • Unit tests
@WaldoFR WaldoFR modified the milestone: Version 3.1.0-alpha.1 Jun 15, 2018
brigittehuynh added a commit that referenced this issue Aug 21, 2018
@brigittehuynh
#115 Added the COM.FLOW.FilePath, largely updating the old version using
11805d9 
the COM.FLOW.FileExistence rule for recognizing file strings and adding
file management commands.
The tests files were updated accordingly.
@brigittehuynh
Copy link
Collaborator

The localization remains for the moment the basic detection of functions, not including nested ones.

Compared with COM.FLOW.FileExistence, the n and z options (string options) were removed. This might need to be done in COM.FLOW.FileExistence, or not.

@brigittehuynh brigittehuynh mentioned this issue Aug 22, 2018
Merged
@WaldoFR WaldoFR mentioned this issue Sep 13, 2018
Merged
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#115 Added the COM.FLOW.FilePath, largely updating the old …
aea308d 
…version using

the COM.FLOW.FileExistence rule for recognizing file strings and adding
file management commands.
The tests files were updated accordingly.
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#115 Added the COM.FLOW.FilePath, largely updating the old version using
fa498f4 
the COM.FLOW.FileExistence rule for recognizing file strings and adding
file management commands.
The tests files were updated accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brigittehuynh brigittehuynh

Labels
enhancement shell
Projects
None yet
Milestone
Version 3.1.0-alpha.4
Development

Successfully merging a pull request may close this issue.

v3.1.0 cnescatlab/i-CodeCNES
2 participants
@WaldoFR @brigittehuynh