Match insecure registry behavior from Docker #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks how we create a resolver so that we handle plain http connections, and TLS validation the same way as Docker.
The impact is that you only need to specify that a registry is insecure when:
When I was looking at the docker library we are using to create a resolver, I saw that we were using deprecated functionality. By using the Hosts function that is called per registry to determine how to connect to that registry, I was able to simplify the resolver and not need to create 3 separate resolvers.