Add applyTo to Credentials #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow restricting a credential to a list of actions, just like Parameters can do today. This allows a credential to not have to be passed in for actions that do not use it. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
added a commit
to carolynvs/cnab-go
that referenced
this pull request
Feb 17, 2021
Bundles may set the applyTo field on credentials. When it is set, only require the credential when it applies to the specified action. Implements cnabio/cnab-spec#407 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Feb 18, 2021
|
Correct, this doesn't change existing behavior when applyTo is not set. We talked about it in the CNAB meeting with Matt and Chris and agreed this is a minor spec change. |
simongdavies
pushed a commit
to simongdavies/cnab-go
that referenced
this pull request
Mar 31, 2021
Bundles may set the applyTo field on credentials. When it is set, only require the credential when it applies to the specified action. Implements cnabio/cnab-spec#407 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow restricting a credential to a list of actions, just like Parameters can do today. This allows a credential to not have to be
passed in for actions that do not use it.
Closes #366