-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNAB Security 1.0 GA #376
CNAB Security 1.0 GA #376
Conversation
Signed-off-by: Radu M <root@radu.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve (LGTM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @trishankatdatadog and @radu-matei for all the great work on this!
fantastic work, actually. amazing, tremendous labors all. On to the example and blog for it!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @radu-matei and @trishankatdatadog !
So say we all 💯 |
Can someone put this on a branch that @chris-crone and I can vote on and tag? I think @vdice is the resident expert on this process. |
@technosophos the cnab-security-1.0.0-ga branch has now been created. It sounds like we'll wait on creation of the tag until the vote has been held. |
Chris and I both voted on this issue, but met today and re-confirmed that we believe the proposal is ready for release. Therefore, this proposal has been ratified. |
This commit marks the Working Group Acceptance (GA) of the CNAB Security 1.0 specification.
According to the OWNERS file, the following people must vote:
@radu-matei
@technosophos
@jeremyrickard
@silvin-lubecki
@jlegrone
@carolynvs
cc @chris-crone, @trishankatdatadog, @squillace