Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNAB Security 1.0 GA #376

Merged
merged 1 commit into from
Jun 30, 2020
Merged

CNAB Security 1.0 GA #376

merged 1 commit into from
Jun 30, 2020

Conversation

radu-matei
Copy link
Member

@radu-matei radu-matei commented Jun 24, 2020

This commit marks the Working Group Acceptance (GA) of the CNAB Security 1.0 specification.

According to the OWNERS file, the following people must vote:

@radu-matei
@technosophos
@jeremyrickard
@silvin-lubecki
@jlegrone
@carolynvs

cc @chris-crone, @trishankatdatadog, @squillace

Signed-off-by: Radu M <root@radu.sh>
Copy link
Member Author

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve (LGTM)

Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @trishankatdatadog and @radu-matei for all the great work on this!

@squillace
Copy link

fantastic work, actually. amazing, tremendous labors all. On to the example and blog for it!!!!

Copy link
Member

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @radu-matei and @trishankatdatadog !

@carolynvs
Copy link
Contributor

So say we all 💯

@carolynvs carolynvs merged commit 82335b7 into cnabio:master Jun 30, 2020
@technosophos
Copy link
Member

Can someone put this on a branch that @chris-crone and I can vote on and tag? I think @vdice is the resident expert on this process.

@vdice
Copy link
Member

vdice commented Jun 30, 2020

@technosophos the cnab-security-1.0.0-ga branch has now been created. It sounds like we'll wait on creation of the tag until the vote has been held.

@technosophos
Copy link
Member

Chris and I both voted on this issue, but met today and re-confirmed that we believe the proposal is ready for release. Therefore, this proposal has been ratified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants