Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Approval for CNAB Core 1.0 Specification #277

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

technosophos
Copy link
Member

This commit indicates that the CNAB specification is now a published final version.

This requires unanimous approval from the executive directors. The following people MUST mark this LGTM:

@chris-crone
@technosophos

When this PR is merged, the tag cnab-core-1.0 should be created in Git.

As with any other PR, all are welcomed to review this PR for grammar, wording, spelling, and technical correctness.

This commit indicates that the CNAB specification is now a published final version.
@technosophos
Copy link
Member Author

LGTM

Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nitty nits that don't matter

README.md Outdated Show resolved Hide resolved
100-CNAB.md Outdated Show resolved Hide resolved
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the comments from @carolynvs

technosophos and others added 2 commits September 6, 2019 15:36
Co-Authored-By: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>
Co-Authored-By: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>
@technosophos technosophos merged commit e71f7f2 into cnabio:master Sep 6, 2019
@technosophos technosophos deleted the cnab-core-1.0-ad branch September 6, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants