Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large build system and small API modernizations #250

Merged
merged 96 commits into from
Jun 9, 2022

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Jun 8, 2022

Ideally this would be a couple different PRs. It:

  • Switches to CMake and incorporates all of SphinxBase to simplify life for people wanting to compile it.
  • Removes the audio library because it is based on a totally obsolete model of audio processing (/dev/audio from good old SunOS) and it is too difficult to make a cross-platform abstraction based on this.
  • Removes a few deprecated APIs (ARG_FLOAT32 and ARG_FLOAT64, and the non-reentrant parts of cmd_ln.h)
  • Clarifies pointer ownership in a few places
  • Hopefully fixes problems on big-endian machines (Testsuite fails on several archs sphinxbase#77 and Some tests fail on big endian architectures sphinxbase#86)
  • Adds a -loglevel argument and makes logging quieter by default

The goal is to get a truly stable release since PocketSphinx is no longer a development system.

Copy link
Contributor

@lenzo-ka lenzo-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make doxygen not required?

@dhdaines
Copy link
Contributor Author

dhdaines commented Jun 8, 2022 via email

@dhdaines
Copy link
Contributor Author

dhdaines commented Jun 8, 2022

Can you make doxygen not required?

should be done in 561a4b1

Copy link
Contributor

@lenzo-ka lenzo-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

src/util/blas_lite.c Show resolved Hide resolved
test/unit/test_util/test_fopen.c Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Show resolved Hide resolved
@lenzo-ka
Copy link
Contributor

lenzo-ka commented Jun 8, 2022

I'm using pyenv, and cmake seems to get a little confused about which SDK to build for -- it complains (but works) at link time about the python version and the current build target. We can figure this out later...

[100%] Linking C shared module _pocketsphinx_python.so
ld: warning: object file (/Users/kal/.pyenv/versions/3.9.9/lib/libpython3.9.a(getargs.o)) was built for newer macOS version (12.3) than being linked (12.0)

... and more like that.

@dhdaines dhdaines merged commit 4f07168 into cmusphinx:master Jun 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants