Make both ME1a and ME1b LCT (A/CLCT) sorted into ring 1.

[sifuluo]

PR description:

This PR changed the ring index of A/C/LCTs in ME1a from 4 to 1, making the ME1a and ME1b be stored at the same container.
The function that calculate the GlobalPoint will take care of the ME1a entries based on the half-strip number of the LCT.

Previously the the CSCStubMatcher will process the A/C/LCTs and sort them by the CSCDetID of the SimHits they are matched to.
Because the DIGI-tier sample does not distinguish ME1a and ME1b for A/C/LCTs, detector information of SimHits has to be used to tell A/C/LCTs from ME1a and ME1b.
But there are cases when both ME1a and ME1b contain the SimHits but LCT is only reconstructed in either. So the LCT would end up in the wrong sorting index (the DetId).
C/LCTs in ME1a and ME1b have different half-strip range, making them easily distinguishable. There is no need to separate ME1a and ME1b in the containers of CSCStubMatcher.

PR validation:

Tested on 100k events of private produced muon gun sample.
Here is a plot of ME1b chamber 1 LCT global points. There are distributions outside the block.
before.pdf
Isolating those entries we found they are from SimHits at the edge.
before_wing.pdf
If we tell whether a LCT is in ME1a or ME1b by the Half Strip, the problematic entries return consistent GlobalPoint with the SimHits.
before_correct.pdf
After this correction, the GlobalPoint of LCTs in ME1b chamber 1 becomes:
Correction.pdf
The ME1a and ME1b LCTs are all in this plot while only the SimHit in ME1b are shown.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

A new Pull Request was created by @sifuluo (Sifu Luo) for CMSSW_12_2_X.

It involves the following packages:

• Validation/MuonCSCDigis (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Make both ME1a and ME1b LCT (A/CLCT) sorted into ring 1. #37188

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d4e44/22947/summary.html
COMMIT: b170c61
CMSSW: CMSSW_12_2_X_2022-03-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37179/22947/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251294
• DQMHistoTests: Total failures: 42
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3251230
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 0 log files, 0 edm output root files, 42 DQM output files

[jfernan2]

@sifuluo I cannot judge if the changes in the CSC Validation plots are meaningful and in the right direction expected from this PR:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_2_X_2022-03-08-1100+6d4e44/48802/dqm-histo-comparison-summary.html

Could you check and give green light if so?
Thanks

[sifuluo]

@jfernan2 Yes, this is what we expected.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@sifuluo @jfernan2 to have this merged in the closed production release 12_2 a master version of this PR must exist. Please provide it even if you plan to implement this only in the online release, so that this update can remain in the forthcoming online releases as well without the need to add it by hand every time.

[sifuluo]

@perrotta The PR of master version is created, see
#37188

[perrotta]

backport of #37188

[perrotta]

+1

• Succefully merged in master since CMSSW_12_4_X_2022-03-11-2300