-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run4-hgx285 Update some of the remaining validation classes in Validation/HGCalValidation #33614
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33614/22454
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33614/22455
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Validation/HGCalValidation @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57d125/14814/llvm-analysis/cmsclangtidy.txt for details. RelVals
Expand to see more relval errors ...RelVals-INPUT
AddOn Tests
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33614/22457
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33614/22460
|
Pull request #33614 was updated. @civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @rvenditti can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57d125/14816/summary.html Comparison SummarySummary:
|
+1 |
+1 Plot HGCAL/HGCalSimHitsV/HitValidation/hebEnRec now gets entries, e.g.: |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update some of the remaining validation classes in Validation/HGCalValidation
PR validation:
Use scripts in Validation/HGCalValidation/test/python to test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special