Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] Simplify makeHGCalValidationPlots #33545

Closed

Conversation

lecriste
Copy link
Contributor

PR description:

This PR simplifies the code in makeHGCalValidationPlots.py
No changes are expected in the output.
It must be merged after PR#33488

PR validation:

runTheMatrix -l limited

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Apr 27, 2021
@lecriste lecriste changed the title Make hg cal validation plots simplify master [HGCAL] Simplify makeHGCalValidationPlots Apr 27, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33545/22326

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

RecoHGCal/Configuration
RecoHGCal/TICL
RecoParticleFlow/PFClusterProducer
Validation/HGCalValidation

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @srimanob, @jfernan2, @ahmad3213, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@mmarionncern, @sethzenz, @bsunanda, @clelange, @felicepantaleo, @cbernet, @vandreev11, @rovere, @lgray, @cseez, @apsallid, @sobhatta, @pfs, @hatakeyamak, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor

rovere commented Apr 28, 2021

@lecriste from a quick look, it seems to me that this PR embeds #33488: is that right? I believe git will find its way out of it, but I'd prefer to have just the last 2 commits submitted, eventually after #33488 has been merged.
Would you agree with that?

@lecriste
Copy link
Contributor Author

lecriste commented May 5, 2021

Closing to open another with clean history.

@lecriste lecriste closed this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants