Update template and gen errors for phase-2 geometries with 3D pixels

[OzAmram]

This PR updates the template and generror objects for the pixel geometries with 3D pixels. It also removes the process modifier for the T23 geometry that turns off the template reconstruction.

Testing

The pixel hit residuals & pulls for the 3D layers have been checked with these new conditions.
This PR, together with #33495, has been show to fix slightly poor performance of the template reconstruction seen in the 3D pixels.
Link to slides.

[OzAmram]

@mmusich @tsusa @emiglior @tvami @pmaksim1 @perrotta @slava77 @duartej

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33508/22247

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Redesign all GPU workflows to detect if a GPU is present, and fall back to CPU otherwise #33428, Add new workflows to upgradeWorkflowComponents.py for HLT #33461, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation

@malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @christopheralanwest, @kpedro88, @cmsbuild, @srimanob, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @tocheng, @Martin-Grunewald, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• workflow = 35834.0, 36234.0, 36634.0

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cda897/14529/summary.html
COMMIT: 4e69386
CMSSW: CMSSW_12_0_X_2021-04-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33508/14529/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cda897/35834.0_TTbar_14TeV+2026D79+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cda897/36234.0_TTbar_14TeV+2026D80+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cda897/36634.0_TTbar_14TeV+2026D81+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877023
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[tlampen]

+alca

-update of template and generror objects for pixel geometries with 3D pixels + removal of process modifier for the T23 geometry that turns off the template reconstruction
-no changes expected or observed in any workflow
-changes illustrated in the linked slides

[mmusich]

Hi @cms-sw/upgrade-l2 @cms-sw/pdmv-l2 can you please review?
It would be great if this could be accepted by the time of 12_0_0_pre1.
Thanks,
Marco

[srimanob]

Hi @OzAmram @mmusich

Just to clarify, what is the expectation of this PR without #33495. Change or no change? I also confuse in @tlampen summary (no changes expected in any workflow, but then changes illustrated in the linked slides)

As mentioned in the PR description, it seems that you expect to trigger the test with #33495.

Thanks.

[mmusich]

@srimanob, changes are expected for the geometries featuring T23, T25 and T26 (so the ones with 3D Pixels).
None of those is excercized in the standard matrix, so you won't be able to see changes in the PR tests, hence @tlampen anaylsis is correct.
The changes in the conditions proposed here factorize fully with #33495 (which is a generic bug-fix affecting even Phase-1).
On the other hand both PRs are desirable to be merged, as they (together) will fix the issue reported in #33495 (comment)
At any rate #33495 now is merged.

[srimanob]

+Upgrade

Thanks for the clarification. It should be better to state clearly in the description what to expect/not to expect to see with the PR if no need to test with other PR.

[chayanit]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1