Backport #31927 (PuppiMET with PUPPIv15 and UL17 PUID) #32076

alefisico · 2020-11-10T10:50:03Z

PR description:

This PR only affects nanoAOD.
It includes the PuppiMET collection with the new PUPPIv15.
Additionally updates the training for PUID to UL17.
Fix jetID for FatJet in nanoAOD

This is a backport of #31927.

cmsbuild · 2020-11-10T10:50:33Z

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2020-11-10T11:06:20Z

please test

cmsbuild · 2020-11-10T11:06:44Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-11-09-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10611/console Started: 2020/11/10 12:07

cmsbuild · 2020-11-10T12:28:06Z

+1
Tested at: 71fe432
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31b48b/10611/summary.html
CMSSW: CMSSW_10_6_X_2020-11-09-2300
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-11-10T12:28:07Z

Comparison job queued.

cmsbuild · 2020-11-10T14:28:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31b48b/10611/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214708
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214373
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 14 edm output root files, 34 DQM output files

mariadalfonso · 2020-11-10T19:49:55Z

master has one more change
https://github.com/cms-sw/cmssw/pull/31927/files?diff=unified&w=1#diff-79860e2d37e9cc0867e9de61faab9b79e0283ebf986856b7a05f517e6d1d083aL1640-R1640

need to verify that the
PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py
got right all previous backport (the history of 10_6 and 11_1 diverged end of 2019)
@ahinzmann @alefisico @lathomas @slava77

it also seems that as it is now the rawPuppi doesn't change (and we want to change a bit because we are getting the V11--> V15 tune)

DataUL16_106_rawPuppi

DataUL17_112_rawPuppi

file used : /store/data/Run2017F/DoubleMuon/MINIAOD/09Aug2019_UL2017-v1/50000/F9D57A9E-4E78-8647-862E-606EB9DC1665.root
Blue is the reference file read in both 10_6 and 11_2, while the black should contain the effect of this PR

lathomas · 2020-11-11T02:11:42Z

PhysicsTools/NanoAOD/python/nano_cff.py

@@ -213,6 +213,35 @@ def nanoAOD_recalibrateMETs(process,isData):
    process.metTables += process.corrT1METJetTable
 #    makePuppiesFromMiniAOD(process,True) # call this before in the global customizer otherwise it would reset photon IDs in VID
    runMetCorAndUncFromMiniAOD(process,isData=isData,metType="Puppi",postfix="Puppi",jetFlavor="AK4PFPuppi")


Shouldn't this line be commented? This could likely explain @mariadalfonso 's observation (no difference in raw puppi met before/after the fix)

right, it's removed in master as now the runMetCorAndUncFromMiniAOD is called 5 lines after

ups sorry, my bad. I'll fix it now

cmsbuild · 2020-11-11T15:59:51Z

Pull request #32076 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please check and sign again.

cmsbuild · 2020-11-26T16:38:51Z

Pull request #32076 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please check and sign again.

perrotta · 2020-11-26T17:14:36Z

please test

cmsbuild · 2020-11-26T17:14:57Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-11-26-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11082/console Started: 2020/11/26 18:15

cmsbuild · 2020-11-26T18:43:45Z

+1
Tested at: 1d43e87
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31b48b/11082/summary.html
CMSSW: CMSSW_10_6_X_2020-11-26-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-11-26T18:43:47Z

Comparison job queued.

cmsbuild · 2020-11-26T20:28:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31b48b/11082/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214712
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214377
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 26 edm output root files, 34 DQM output files

mariadalfonso · 2020-11-27T08:20:23Z

+xPOG
changes as in
#32076 (comment)

perrotta · 2020-11-27T08:39:54Z

+1

Not simply a backport of PuppiMET with PUPPIv15 and UL17 PUID #31927, as features from PUPPI MET in RECO #29254 (Puppi MET) are also included at least
Mostly intended for nanoAOD, the only updates in the miniAOD workflow are now ruled by the run2_miniAOD_UL modifier
Jenkins tests pass and show no differences wrt baseline in the standard workflows
re-miniAOD updates end up with minor differences in outputs, which allow synchronization with what is in the master and have been approved by XPOG (see e.g. Backport #31927 (PuppiMET with PUPPIv15 and UL17 PUID) #32076 (comment) and related discussions)

silviodonato · 2020-11-27T09:59:03Z

+1

silviodonato · 2020-11-27T11:41:07Z

merge

santocch · 2020-11-29T09:41:07Z

+1

cmsbuild · 2020-11-29T09:41:27Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will be automatically merged.

adding PuppiMET with PuppiV15 and latest PUID

71fe432

cmsbuild added this to the CMSSW_10_6_X milestone Nov 10, 2020

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures tests-pending xpog-pending labels Nov 10, 2020

mariadalfonso mentioned this pull request Nov 10, 2020

features for V8 nanoAOD cms-nanoAOD/cmssw#533

Closed

55 tasks

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2020

lathomas reviewed Nov 11, 2020

View reviewed changes

adding srcWeights

13fdef7

cmsbuild added comparison-pending and removed comparison-available tests-approved labels Nov 11, 2020

cmsbuild added reconstruction-pending tests-pending labels Nov 11, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 26, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 26, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 26, 2020

cmsbuild added xpog-approved and removed xpog-pending labels Nov 27, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 27, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 27, 2020

silviodonato merged commit e133f95 into cms-sw:CMSSW_10_6_X Nov 27, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Nov 29, 2020

lathomas mentioned this pull request Nov 30, 2020

PUPPI v15 bug/crash fix for NANOAOD (106X backport) #32329

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport #31927 (PuppiMET with PUPPIv15 and UL17 PUID) #32076

Backport #31927 (PuppiMET with PUPPIv15 and UL17 PUID) #32076

alefisico commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020

mariadalfonso commented Nov 10, 2020

cmsbuild commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

mariadalfonso commented Nov 10, 2020 •

edited

Loading

lathomas Nov 11, 2020

mariadalfonso Nov 11, 2020

alefisico Nov 11, 2020

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 26, 2020

perrotta commented Nov 26, 2020

cmsbuild commented Nov 26, 2020 •

edited

Loading

cmsbuild commented Nov 26, 2020

cmsbuild commented Nov 26, 2020

cmsbuild commented Nov 26, 2020

mariadalfonso commented Nov 27, 2020

perrotta commented Nov 27, 2020

silviodonato commented Nov 27, 2020

silviodonato commented Nov 27, 2020

santocch commented Nov 29, 2020

cmsbuild commented Nov 29, 2020

Backport #31927 (PuppiMET with PUPPIv15 and UL17 PUID) #32076

Backport #31927 (PuppiMET with PUPPIv15 and UL17 PUID) #32076

Conversation

alefisico commented Nov 10, 2020 • edited Loading

PR description:

cmsbuild commented Nov 10, 2020

mariadalfonso commented Nov 10, 2020

cmsbuild commented Nov 10, 2020 • edited Loading

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

mariadalfonso commented Nov 10, 2020 • edited Loading

lathomas Nov 11, 2020

Choose a reason for hiding this comment

mariadalfonso Nov 11, 2020

Choose a reason for hiding this comment

alefisico Nov 11, 2020

Choose a reason for hiding this comment

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 26, 2020

perrotta commented Nov 26, 2020

cmsbuild commented Nov 26, 2020 • edited Loading

cmsbuild commented Nov 26, 2020

cmsbuild commented Nov 26, 2020

cmsbuild commented Nov 26, 2020

mariadalfonso commented Nov 27, 2020

perrotta commented Nov 27, 2020

silviodonato commented Nov 27, 2020

silviodonato commented Nov 27, 2020

santocch commented Nov 29, 2020

cmsbuild commented Nov 29, 2020

alefisico commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020 •

edited

Loading

mariadalfonso commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 26, 2020 •

edited

Loading