-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCAL] Corrections in noise vector in CLUE #32021
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32021/19561
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32021/19563
|
A new Pull Request was created by @apsallid for master. It involves the following packages: RecoLocalCalo/HGCalRecProducers @perrotta, @jpata, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
This should fix #31940 for HGCAL. On a side note: are we sure that also the |
The code-checks are being triggered in jenkins. |
@rovere @mariadalfonso With the operator [] no problem is observed, however using .at(location) which also checks for the range an exception is thrown. So, I changed the relevant parameter which for HGCAL is 6 to 3 for HFNose to avoid the crash but then switch back to the faster operator[]. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32021/19568
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
From RecoLocalCalo/HGCalRecProducers/plugins/HGCalCLUEAlgo.cc:
It implies that the vectors
This PR imports twice in the hgcalLayerClusters configuration the same vectors For my own understanding: why the
|
Hi @perrotta , The physical thicknesses at CE_E is the same as the thicknesses in CE_H. Initially, HGCal used 3 thickness correction factors to equalize the signal scale in the detector, coming from the silicon in CE_E. However, later it was proven that 3 factors weren't adequate to equalize the signal in all detector. Silicon in the CE_H part needed different factors. The term we use now is regional em factors since from 3 we ended up using 7. The "1" in the On your question: I know that @rovere is strongly considering the cleaning and reorganization of the code. |
+1
|
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This reverts commit 02d8281.
PR description:
With the introduction of 7 regional factors (6 for silicon plus 1 for scintillator), the fcPerMip and
noises vectors should be guaranteed that they have 6 entries. We alter the way the noises vector is extended, since it uses the
isNose_
member variable before the variable is set, while theinsert
method should not be called using iterators that refer to the very same vector we are trying to extend.PR validation:
No difference is observed to the printout information.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport.