Add PbPb modifications to egamma sequences to Run 3 era

[mandrenguyen]

PR description:

This PR fixes the exception in
#31894

The issue arose in #31668 when I separated the pp_on_AA_2018 and pp_on_PbPb_run3 eras. The modifications to the photon code for heavy ions were only in the former.
This PR adds them to the latter.

Tested on 159.1 and 140.5611

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31897/19301

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/Configuration
RecoEgamma/EgammaPhotonProducers

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @hatakeyamak, @emilbols, @varuns23, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @lgray, @jdolen, @ferencek, @Sam-Harper, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @sobhatta, @lecriste, @afiqaize, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test workflow 159.1,310.0

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 159.1,310.0
• CMSSW_11_2_X_2020-10-21-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10196/console Started: 2020/10/22 11:19

[silviodonato]

urgent

[cmsbuild]

+1
Tested at: 443911e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0e00c/10196/summary.html
CMSSW: CMSSW_11_2_X_2020-10-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[slava77]

apparently this PR combines

• a bugfix to known crashes in a somewhat undesireable way (reinforcing dependency on puppi)
• bugfixes to workflows for parts that were missing for pp_on_PbPb_run3 (new features in the context of bugfixing the crash).

@mandrenguyen
did you check if there is a way to disable reading of PUPPI in egamma iso?

[slava77]

in the previous PR for HI jets the goal was to not run PUPPI in HI.
the goal is to clean up this dependence where possible, not to increase it (#31647)

[slava77]

a bugfix to known crashes in a somewhat undesireable way (reinforcing dependency on puppi)

OTOH, I guess this brings Run3 part on par with the "undesireable way" already done in other variants of pp_on_AA.
So, the implementation in this PR in miniAOD_tools.py is OK then

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0e00c/10196/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b0e00c/159.1_QCD_Pt_80_120_14_HI_2021+QCD_Pt_80_120_14_HI_2021+DIGIHI2021PPRECO+RECOHI2021PPRECO+HARVESTHI2021PPRECO
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b0e00c/310.0_Pyquen_GammaJet_pt20_2760GeV_2021+Pyquen_GammaJet_pt20_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544110
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544087
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[slava77]

+1

for #31897 443911e

• IIUC, this is just a minimal fix to things that got broken for Run3 HI by Bad PF candidate filter for 2018 PbPb data #31668 ; the crashing HI Run3 workflows now run

[silviodonato]

+1

[silviodonato]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.