-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEM unpacker: bugfix and more cross checks #31863
GEM unpacker: bugfix and more cross checks #31863
Conversation
only 12 AMCs can be readout GEMRawToDigiModule - fix gem digi bx
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31863/19221
|
A new Pull Request was created by @jshlee (Jason Lee) for master. It involves the following packages: DataFormats/GEMDigi @perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
} | ||
// compare trailers | ||
if (amc13Event->fragmentLength() != trailer.fragmentLength()) { | ||
edm::LogWarning("GEMRawToDigiModule") << " fragmentLength miss match"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: miss match -> mismatch (also in next few lines)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in all of these messages (also in the next file), it might be useful to print the actual mismatched values as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kpedro88!
I'll fix them after the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values for amc13Event and trailer would not be that useful, since they should be reading the same data.
This test is to just make sure that they are both reading the last data line.
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31863/19330
|
@cmsbuild please test |
The tests are being triggered in jenkins.
|
@cms-sw/simulation-l2 @cms-sw/upgrade-l2 @cms-sw/db-l2 |
I have no other comments; will sign once tests pass. |
-1 Tested at: 78a7536 CMSSW: CMSSW_11_2_X_2020-10-21-2300 I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Oct 22 20:07:34 2020-date Thu Oct 22 19:59:32 2020 s - exit: 34304 |
Comparison job queued. |
The error is in the very last line of
I hope it is just a transient problem |
Yes, we saw that same problem here #31602 (comment) and it went away by running one more time the test. Same thing here #31792 (comment) |
+1
|
Comparison is ready Comparison Summary:
|
merge |
PR description:
GEMDigiToRawModule issue with packing large data
GEMRawToDigiModule
No changes are expected for non PU samples.
PU should be back to 11_2_0pre1
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR: