-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move from MagneticField_AutoFromDBCurrent_cff to MagneticField in all Tracker-related configurations #31788
move from MagneticField_AutoFromDBCurrent_cff to MagneticField in all Tracker-related configurations #31788
Conversation
… all Tracker DPG-owned configurations
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31788/19053
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @perrotta, @andrius-k, @yuanchao, @kmaeshima, @tlampen, @christopheralanwest, @ErnestaP, @tocheng, @cmsbuild, @jpata, @jfernan2, @fioriNTU, @slava77, @ggovi, @pohsun, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1
|
kind reminder @cms-sw/alca-l2 @cms-sw/db-l2 |
+1 |
urgent |
merge |
PR description:
It has been hinted in #31651 (comment) that the
MagneticField_AutoFromDBCurrent_cff
configuration fragment might get to be obsoleted soon.Looking into it, it just imports
Configuration.StandardSequences.MagneticField_cff
:cmssw/Configuration/StandardSequences/python/MagneticField_AutoFromDBCurrent_cff.py
Lines 1 to 6 in d3fe185
I've moved all the pieces of configuration that are broadly speaking under the responsibility of Tracker DPG to
Configuration.StandardSequences.MagneticField_cff
and removed them where duplicated.This should solve quite a few of the failing unit tests spotted in #31651 (comment)
PR validation:
Compiles. No regressions are expected as the generated configurations should be verbatim the same.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport is needed.