-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt EgammaHadTower and ElectronHcalHelper classes to use ESGetToken #31700
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31700/18861
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoEgamma/EgammaElectronAlgos @perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Some of the RecoEgamma plugins are not trivial to migrate to the ES tokens because the EventSetup gets passed through many layers of helper-class abstractions. Turning the former EgammaHadTower helper class (that took the EventSetup as a constructor argument) to free functions that take the ES products directly would remove one of these abstraction layers, making it simpler to migrate some of electron and photon reconstruction plugins.
Another helper class that also makes use of EgammaHadTower is the ElectronHcalHelper, which is now using the ESGetTokens.
PR validation:
Local matrix tests pass.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.