Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676

abaty · 2020-10-06T02:29:13Z

PR description:

This PR adds an additional (non-default) functionality to the primary vertex producer which allows it to search an existing vertex collection, and re-run the vertexing algorithms if an event does not contain a previously found PV. If a vertex has been previously found, the first vertex is copied into the new collection.

This is of relevance in 2018 HI collisions, where some track selections had to be applied to the tracks input into the PV step for timing purposes. This caused some events with a few low-pt tracks (which failed cuts) to not have a PV found. These vertices can be recovered by re-running the vertexing with looser cuts, but we cannot afford to run the vertexing with loose cuts on every event because the timing in central events.

In the 2018 miniAOD workflow, we create and run this 'recovery' module and store it as a new slimmed vertex collection for future use in the event selection of HI events. The new collection's size is about a 0.1% increase in the total file size, and the timing impact is negligible, as only ~5% of events have a recoverable vertex that has not already been found.

Some info can be found on slides 6 and 7 of this presentation in the HI PAG meeting: slides

PR validation:

The PR was tested using the configuration file at /afs/cern.ch/user/a/abaty/work/public/forPeople/forChi2PR
An example of the Z distribution of vertices recovered can be found on the previously mentioned slides, which around 5% additional vertices found in the recovery collection.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@mandrenguyen

cmsbuild · 2020-10-06T02:29:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-06T02:34:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31676/18807

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): HeavyIon Reaction Plane MiniAOD #31129, Bad PF candidate filter for 2018 PbPb data #31668, Include the HF filters used in heavy ions using struct in the MiniAOD content #31602
- File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): HeavyIon Reaction Plane MiniAOD #31129, Bad PF candidate filter for 2018 PbPb data #31668, Include the HF filters used in heavy ions using struct in the MiniAOD content #31602

cmsbuild · 2020-10-06T02:35:24Z

A new Pull Request was created by @abaty for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoHI/HiTracking
RecoVertex/PrimaryVertexProducer

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @echapon, @ahinzmann, @peruzzim, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @JanFSchulte, @jdolen, @ferencek, @mandrenguyen, @yetkinyilmaz, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @mtosi, @dgulhan, @clelange, @riga, @jazzitup, @JyothsnaKomaragiri, @yenjie, @kurtejung, @gpetruc, @mariadalfonso, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-10-06T02:42:40Z

@cmsbuild please test

cmsbuild · 2020-10-06T02:43:04Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-05-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9748/console Started: 2020/10/06 06:20

cmsbuild · 2020-10-06T05:31:01Z

-1

Tested at: 9f7ab42

CMSSW: CMSSW_11_2_X_2020-10-05-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aef504/9748/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.793 step3

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step3_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

136.874 step3

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step3_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step3_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step3_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

11634.0 step3

runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA/step3_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA.log

12434.0 step3

runTheMatrix-results/12434.0_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA/step3_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano/step3_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

28234.0 step3

runTheMatrix-results/28234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

23434.999 step4

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step4_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

cmsbuild · 2020-10-06T05:31:03Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

… Pset

slava77 · 2020-10-27T12:25:22Z

@cmsbuild please test

to get cleaner comparisons

cmsbuild · 2020-10-27T12:25:43Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-26-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10317/console Started: 2020/10/27 19:34

cmsbuild · 2020-10-27T20:06:36Z

+1
Tested at: 7d0d84c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aef504/10317/summary.html
CMSSW: CMSSW_11_2_X_2020-10-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-27T20:06:38Z

Comparison job queued.

cmsbuild · 2020-10-27T21:45:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aef504/10317/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544092
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544069
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

slava77 · 2020-10-28T01:07:48Z

+1

for #31676 7d0d84c

code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show that a new product of type vector<reco::Vertex> named offlineSlimmedPrimaryVerticesRecovery is now showing up in the output of HI miniAOD , as seen in wf 158.01

santocch · 2020-10-28T13:45:02Z

+1

cmsbuild · 2020-10-28T13:45:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-10-29T00:22:43Z

+1

abaty added 2 commits October 2, 2020 08:57

added Vertex Recovery option for HI

a0881f5

added code format and checks

9f7ab42

cmsbuild added this to the CMSSW_11_2_X milestone Oct 6, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 6, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 6, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 6, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 6, 2020

cmsbuild mentioned this pull request Oct 6, 2020

Bad PF candidate filter for 2018 PbPb data #31668

Merged

made import more specific to avoid bugs and included default param in…

21e5a2b

… Pset

cmsbuild removed code-checks-approved comparison-notrun tests-rejected labels Oct 7, 2020

cmsbuild added the comparison-available label Oct 27, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Oct 27, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 27, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 27, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 27, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 28, 2020

cmsbuild mentioned this pull request Oct 28, 2020

add ZDC Digis to HI miniAOD #31971

Merged

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Oct 28, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 29, 2020

cmsbuild merged commit 9f65642 into cms-sw:master Oct 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676

Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676

abaty commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

slava77 commented Oct 6, 2020

cmsbuild commented Oct 6, 2020 •

edited

Loading

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

slava77 commented Oct 27, 2020

cmsbuild commented Oct 27, 2020 •

edited

Loading

cmsbuild commented Oct 27, 2020

cmsbuild commented Oct 27, 2020

cmsbuild commented Oct 27, 2020

slava77 commented Oct 28, 2020

santocch commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

qliphy commented Oct 29, 2020

Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676

Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676

Conversation

abaty commented Oct 6, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

slava77 commented Oct 6, 2020

cmsbuild commented Oct 6, 2020 • edited Loading

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

slava77 commented Oct 27, 2020

cmsbuild commented Oct 27, 2020 • edited Loading

cmsbuild commented Oct 27, 2020

cmsbuild commented Oct 27, 2020

cmsbuild commented Oct 27, 2020

slava77 commented Oct 28, 2020

santocch commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

qliphy commented Oct 29, 2020

cmsbuild commented Oct 6, 2020 •

edited

Loading

cmsbuild commented Oct 27, 2020 •

edited

Loading