HCAL Pulse Filtering for OOT PU Subtraction

[JHiltbrand]

PR description:

This PR adds functionality to do simple pulse filtering when emulating HCAL (HBHE) trigger primitives. This is achieved by supplying vectors of weights to the peak finder algorithm already implemented in the HcalTriggerPrimitiveAlgo package. By default, without any explicit configuration, the nominal result is obtained (no subtraction). Configuration of the vector or weights, number of presamples, pulse containment correction, etc can be specified via python. A twiki page documents the use cases for specifying different filters and explains the variables added/used.

The proposed changes only have an effect for TPs emulated from QIE11 data frames.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31661/18769

• This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31661/18769/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31661/18769/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[abdoulline]

Josh,
please, do what cmsbild bot suggests: scram build code-format in your local (baranch-making) release area and commit the changes (once again) to update your branch.
Then this change will be immediately propagated to this PR. In general it's worth doing it before submitting PR.

[cmsbuild]

The code-checks are being triggered in jenkins.

[JHiltbrand]

Josh,
please, do what cmsbild bot suggests: scram build code-format in your local (baranch-making) release area and commit the changes (once again) to update your branch.
Then this change will be immediately propagated to this PR. In general it's worth doing it before submitting PR.

Ah, sorry about that, just pushed those changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31661/18779

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @JHiltbrand (Joshua Hiltbrand) for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGEventSetup
SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@benkrikler, @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @abdoulline, @rovere, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 167641d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31f3be/10104/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31f3be/10104/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543723
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[JHiltbrand]

Hello @benkrikler, @yuanchao, @christopheralanwest, @tocheng, @rekovic, @tlampen, @pohsun,

It seems the above tests passed. If nothing else needs to be changed on my part please review again and eventually sign at the next convenience.

[christopheralanwest]

+alca

[silviodonato]

@cms-sw/l1-l2 please review/sign

[silviodonato]

@cms-sw/l1-l2 please review/sign

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

@JHiltbrand this PR creates some problems. Please look at #32047