Add low-pT electrons to MINIAOD, update ID, improve end user experience #31220
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <use name="CommonTools/MVAUtils"/> | ||
|
|
||
| <bin name="convertXMLToGBRForestROOT" file="convertXMLToGBRForestROOT.cc"> | ||
| </bin> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| #include "CommonTools/MVAUtils/interface/GBRForestTools.h" | ||
|
|
||
| #include "TFile.h" | ||
|
|
||
| #include <filesystem> | ||
| #include <iostream> | ||
|
|
||
| int main(int argc, char **argv) { | ||
| if (argc != 3) { | ||
| std::cout << "Please pass a (gzipped) BDT weight file and a name for the output ROOT file." << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| char *inputFileName = argv[1]; | ||
| char *outputFileName = argv[2]; | ||
|
|
||
| if (!std::filesystem::exists(inputFileName)) { | ||
| std::cout << "Input file " << inputFileName << " does not exists." << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| if (std::filesystem::exists(outputFileName)) { | ||
| std::cout << "Output file " << outputFileName << " already exists." << std::endl; | ||
| return 1; | ||
| } | ||
|
|
||
| auto gbrForest = createGBRForest(inputFileName); | ||
| std::cout << "Read GBRForest " << inputFileName << " successfully." << std::endl; | ||
|
|
||
| TFile{outputFileName, "RECREATE"}.WriteObject(gbrForest.get(), "gbrForest"); | ||
| std::cout << "GBRForest written to " << outputFileName << " successfully." << std::endl; | ||
|
|
||
| return 0; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,42 +11,49 @@ | |||||||
| ) | ||||||||
|
|
||||||||
| patLowPtElectrons = patElectrons.clone( | ||||||||
|
|
||||||||
| # Input collection | ||||||||
| electronSource = sourceElectrons, | ||||||||
|
|
||||||||
| # MC matching | ||||||||
| genParticleMatch = "lowPtElectronMatch", | ||||||||
|
|
||||||||
| # Electron ID | ||||||||
| addElectronID = True, | ||||||||
| electronIDSources = dict( | ||||||||
| unbiased = cms.InputTag("rekeyLowPtGsfElectronSeedValueMaps:unbiased"), | ||||||||
| ptbiased = cms.InputTag("rekeyLowPtGsfElectronSeedValueMaps:ptbiased"), | ||||||||
| ID = cms.InputTag("lowPtGsfElectronID"), | ||||||||
| ), | ||||||||
|
|
||||||||
| # Embedding of RECO/AOD items | ||||||||
|
|
||||||||
| # Embedding of RECO/AOD items | ||||||||
| embedTrack = True, | ||||||||
| embedGsfElectronCore = True, | ||||||||
| embedGsfTrack = True, | ||||||||
| embedSuperCluster = True, | ||||||||
| embedSeedCluster = True, | ||||||||
| embedBasicClusters = True, | ||||||||
| embedPreshowerClusters = False, | ||||||||
| embedRecHits = False, | ||||||||
| embedPflowSuperCluster = False, | ||||||||
| embedPflowBasicClusters = False, | ||||||||
| embedPflowPreshowerClusters = False, | ||||||||
| embedPFCandidate = False, | ||||||||
|
|
||||||||
| # Miscellaneous flags | ||||||||
| addMVAVariables = False, | ||||||||
| embedHighLevelSelection = False, | ||||||||
| isoDeposits = cms.PSet(), | ||||||||
| isolationValues = cms.PSet(), | ||||||||
| isolationValuesNoPFId = cms.PSet(), | ||||||||
|
|
||||||||
| ) | ||||||||
|
|
||||||||
| makePatLowPtElectronsTask = cms.Task( | ||||||||
| lowPtElectronMatch, | ||||||||
| patLowPtElectrons, | ||||||||
| ) | ||||||||
|
|
||||||||
|
There was a problem hiding this comment.
Suggested change
this would enable re-running of lowPtGsfElectronID only for specific inputs There was a problem hiding this comment. I'm not sure what you mean by this comment. I want to rerun both the ID and the rekey modules for run2_miniAOD_UL. There was a problem hiding this comment. the new version seems OK, the comment was made before rekeying was in the config |
||||||||
| makePatLowPtElectrons = cms.Sequence(makePatLowPtElectronsTask) | ||||||||
|
|
@@ -61,3 +68,12 @@ | |||||||
| electronSource = "gedGsfElectrons", | ||||||||
| genParticleMatch = "electronMatch" | ||||||||
| ) | ||||||||
|
|
||||||||
| # Schedule rekeying of seed BDT ValueMaps by reco::GsfElectron for run2_miniAOD_UL | ||||||||
| from Configuration.ProcessModifiers.run2_miniAOD_UL_cff import run2_miniAOD_UL | ||||||||
| from RecoEgamma.EgammaElectronProducers.lowPtGsfElectronSeedValueMaps_cff import rekeyLowPtGsfElectronSeedValueMaps | ||||||||
| from RecoEgamma.EgammaElectronProducers.lowPtGsfElectronID_cfi import lowPtGsfElectronID | ||||||||
| _makePatLowPtElectronsTask = makePatLowPtElectronsTask.copy() | ||||||||
| _makePatLowPtElectronsTask.add(rekeyLowPtGsfElectronSeedValueMaps) | ||||||||
| _makePatLowPtElectronsTask.add(lowPtGsfElectronID) | ||||||||
| run2_miniAOD_UL.toReplaceWith(makePatLowPtElectronsTask,_makePatLowPtElectronsTask) | ||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these do not exist in the origin, is there really need to add empty sets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are set in the code, here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point is to keep some consistency at the python layer.
So, if this is a clone from
patElectrons, keep things defined consistently.I'd still prefer to only add/modify elements that are different from
patElectrons, but if more things need to be added for cosmetic reasons, please add them in both files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I do edmConfigDump, I see this for my
patLowPtElectron:which means these PSets are being set outside of the cfi file (either in c++ or in other python files).
This is not my desired configuration, hence my explicit override (in python).
Acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it is clear this way.
Thanks.