-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined behavior in MTVHistoProducerAlgoForTracker #31134
Fix undefined behavior in MTVHistoProducerAlgoForTracker #31134
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31134/17745
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Do not read elements off the end of the vectors. This was uncovered by the UBSAN IB.
21cc82c
to
f2c2d96
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31134/17746
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Validation/RecoTrack @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Do not read elements off the end of the vectors. This was uncovered by the UBSAN IB.
PR validation:
Ran workflow 250408.17 step 1 which was previously reporting the UBSAN errors. The addition of the asserts (before using the
if
) were begin triggered. Now the job runs fine.