drop wrong default params in TLorentzVector in TestCorrections.C

[slava77]

tested in root with simple .L TestCorrections.C, which now works

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17239

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17239/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17239/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[slava77]

https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17239/code-format.patch
touches CondFormats/JetMETObjects/test/TestCorrections.C

@mrodozov @smuzaffar
I thought that the code-checks were not supposed to apply to /test directories, even less so to the root scripts.
Is this new?

[mrodozov]

the code checks are not, this is code format. the format will be applied on anything that was touched.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17242

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17242/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17242/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30872/17243

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

CondFormats/JetMETObjects

@ggovi, @cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@mmarionncern, @ahinzmann, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

new IB is out now CMSSW_11_2_X_2020-07-22-1200

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-22-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8225/console Started: 2020/07/22 20:39

[mrodozov]

I know it's weird why it didn't picked it, twice

[slava77]

I know it's weird why it didn't picked it, twice

the artifacts page https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-baseline-tests/
has 22-1200 dated at 20:01.
The last failed attempt has "Started: 2020/07/22 19:47"
It seems reasonable to expect that at 19:47 it couldn't pick up 22-1200 yet.

[cmsbuild]

+1
Tested at: 21e7ea5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36ac49/8225/summary.html
CMSSW: CMSSW_11_2_X_2020-07-22-1200
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[mrodozov]

right thats why, the IB was done earlier but not the baseline

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36ac49/8225/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2526188
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2526140
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[santocch]

+1

[silviodonato]

merge
@ggovi this is a trivial fix in CondFormats/JetMETObjects/test/TestCorrections.C