-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify SonicCore and redesign SonicTriton #30850
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17200
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17202
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: HeterogeneousCore/SonicCore @makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@cmsbuild, please test |
Could you squash the commit history ? |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17339 |
please test |
The tests are being triggered in jenkins.
|
void SonicClientBase::fillBasePSetDescription(edm::ParameterSetDescription& desc, bool allowRetry) { | ||
desc.add<std::string>("mode"); | ||
if (allowRetry) | ||
desc.addUntracked<unsigned>("allowedTries", 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhm, sorry, this was meant for the ifValue
above :-)
int64_t nOutput = sizeShape(); | ||
dataOut.resize(nOutput * batchSize_, 0); | ||
for (unsigned i0 = 0; i0 < batchSize_; ++i0) { | ||
const uint8_t* r0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
+1 |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
SonicCore
w/ helperSonicDispatcher
to reduce templatingSonicClientBase
now handlesmode
andallowedTries
parameters directly (allowedTries
can still be disabled)TritonData
class to handle more Triton features: multiple named inputs/outputs, different input/output types, and variable dimensions (input and output classes forTritonClient
are now maps ofTritonData
objects)SonicTriton
usageSonicTriton
LogInfo time messages slightly to account for above changesPR validation:
Ran
TritonImageProducer
andTritonGraphProducer
many many times (andSonicCore
unit tests).attn: @violatingcp @drankincms @nhanvtran @jeffkrupa @jmduarte @lgray @jpata