Force the definition of the USEHYBRID preprocessor symbol #30684

fwyzard · 2020-07-14T14:42:22Z

PR description:

Force the definition of the USEHYBRID preprocessor symbol in all the L1Trigger/TrackFindingTracklet BuildFiles.

PR validation:

The code now seems to be running fine on a Power8 machine, where before it was crashing before the first event.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #30683

fwyzard · 2020-07-14T14:42:31Z

backport #30683

cmsbuild · 2020-07-14T14:42:52Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Backported from Force the definition of the USEHYBRID preprocessor symbol #30683

fwyzard · 2020-07-14T14:48:55Z

type bug-fix

fwyzard · 2020-07-14T14:49:01Z

urgent

rekovic · 2020-07-14T15:47:07Z

please test

cmsbuild · 2020-07-14T15:47:33Z

The tests are being triggered in jenkins.

CMSSW_11_1_X_2020-07-14-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7933/console Started: 2020/07/14 17:57

cmsbuild · 2020-07-14T17:11:33Z

+1
Tested at: 16b9bcf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7933/summary.html
CMSSW: CMSSW_11_1_X_2020-07-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-14T17:11:35Z

Comparison job queued.

fwyzard · 2020-07-14T18:08:42Z

@cmsbuild, please test for slc7_ppc64le_gcc820

cmsbuild · 2020-07-14T18:09:04Z

The tests are being triggered in jenkins.
Test Parameters:

ARCHITECTURE_FILTER = slc7_ppc64le_gcc820
CMSSW_11_1_X_2020-07-07-2300/slc7_ppc64le_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7937/console Started: 2020/07/14 20:10

cmsbuild · 2020-07-14T19:00:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7933/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780792
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2780741
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

silviodonato · 2020-07-14T20:11:24Z

merge

silviodonato · 2020-07-14T20:11:30Z

merge

cmsbuild · 2020-07-14T20:40:49Z

-1

Tested at: 16b9bcf

CMSSW: CMSSW_11_1_X_2020-07-07-2300
SCRAM_ARCH: slc7_ppc64le_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Backport to 11_1_X of "TTTrack bug fix for POCA" #30666 @tomalin: Backport to 11_1_X of "TTTrack bug fix for POCA"
fix typo in provenance access by L1TTauOffline (backport to 11_1_X) #30573 @swozniewski: fix typo in provenance access by L1TTauOffline (backport to 11_1_X)
Update of the Tracker Online DQM client for Run3 conditions (backport of #30630) #30631 @arossi83: Update of the Tracker Online DQM client for Run3 conditions (backport of Update of the Tracker Online DQM client for Run3 conditions #30630)
Convert the CSCTriggerPrimitivesProducer to a "one" module #30657 @fwyzard: Convert the CSCTriggerPrimitivesProducer to a "one" module
Add L1 hitless seeding for tracking @ HLT (11_1_X) #30574 @cmantill: Add L1 hitless seeding for tracking @ HLT (11_1_X)
Drop unnecessary 'drop *' #30585 @srimanob: Drop unnecessary 'drop *'
PR 11_1_X (backport) L1T TrackTrigger Hybrid Extended ONE Producer. #30616 @cms-l1t-offline: PR 11_1_X (backport) L1T TrackTrigger Hybrid Extended ONE Producer.
Migration of HLT menus to 11_1_0 template (11_1_X) #30550 @cms-tsg-storm: Migration of HLT menus to 11_1_0 template (11_1_X)
[Backport HGC trigger] Replace exception with warning for missing wafer in module mapping #30596 @jbsauvan: [Backport HGC trigger] Replace exception with warning for missing wafer in module mapping
More L1T bug fixes [11.1.x] #30610 @fwyzard: More L1T bug fixes [11.1.x]
fakeEmtfParams name update - Backport to CMSSW_11_1_X #30634 @gekobs: fakeEmtfParams name update - Backport to CMSSW_11_1_X
TrackletEventProcessor: properly initialise and check settings #30660 @fwyzard: TrackletEventProcessor: properly initialise and check settings
Fix L1T bugs and add workflows [11_1_X] #30569 @kpedro88: Fix L1T bugs and add workflows [11_1_X]
Phase2-gex05 Bug fix to Phase2 geometries D49 and higher versions #30603 @bsunanda: Phase2-gex05 Bug fix to Phase2 geometries D49 and higher versions
Fix out-of-bound issue in call to LUT in GEM-CSC trigger [11_1_X] #30607 @dildick: Fix out-of-bound issue in call to LUT in GEM-CSC trigger [11_1_X]
BeamSpotOnline in DQM beamspot clients - backport to 11_1_X #30503 @MilanoBicocca-pix: BeamSpotOnline in DQM beamspot clients - backport to 11_1_X

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7937/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7937/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7937/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test testDD4hepFilteredView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS
---> test TestDQMOnlineClient-dt_dqm_sourceclient had ERRORS
---> test testAlignmentOfflineValidation had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Backport to 11_1_X of "TTTrack bug fix for POCA" #30666 @tomalin: Backport to 11_1_X of "TTTrack bug fix for POCA"
fix typo in provenance access by L1TTauOffline (backport to 11_1_X) #30573 @swozniewski: fix typo in provenance access by L1TTauOffline (backport to 11_1_X)
Update of the Tracker Online DQM client for Run3 conditions (backport of #30630) #30631 @arossi83: Update of the Tracker Online DQM client for Run3 conditions (backport of Update of the Tracker Online DQM client for Run3 conditions #30630)
Convert the CSCTriggerPrimitivesProducer to a "one" module #30657 @fwyzard: Convert the CSCTriggerPrimitivesProducer to a "one" module
Add L1 hitless seeding for tracking @ HLT (11_1_X) #30574 @cmantill: Add L1 hitless seeding for tracking @ HLT (11_1_X)
Drop unnecessary 'drop *' #30585 @srimanob: Drop unnecessary 'drop *'
PR 11_1_X (backport) L1T TrackTrigger Hybrid Extended ONE Producer. #30616 @cms-l1t-offline: PR 11_1_X (backport) L1T TrackTrigger Hybrid Extended ONE Producer.
Migration of HLT menus to 11_1_0 template (11_1_X) #30550 @cms-tsg-storm: Migration of HLT menus to 11_1_0 template (11_1_X)
[Backport HGC trigger] Replace exception with warning for missing wafer in module mapping #30596 @jbsauvan: [Backport HGC trigger] Replace exception with warning for missing wafer in module mapping
More L1T bug fixes [11.1.x] #30610 @fwyzard: More L1T bug fixes [11.1.x]
fakeEmtfParams name update - Backport to CMSSW_11_1_X #30634 @gekobs: fakeEmtfParams name update - Backport to CMSSW_11_1_X
TrackletEventProcessor: properly initialise and check settings #30660 @fwyzard: TrackletEventProcessor: properly initialise and check settings
Fix L1T bugs and add workflows [11_1_X] #30569 @kpedro88: Fix L1T bugs and add workflows [11_1_X]
Phase2-gex05 Bug fix to Phase2 geometries D49 and higher versions #30603 @bsunanda: Phase2-gex05 Bug fix to Phase2 geometries D49 and higher versions
Fix out-of-bound issue in call to LUT in GEM-CSC trigger [11_1_X] #30607 @dildick: Fix out-of-bound issue in call to LUT in GEM-CSC trigger [11_1_X]
BeamSpotOnline in DQM beamspot clients - backport to 11_1_X #30503 @MilanoBicocca-pix: BeamSpotOnline in DQM beamspot clients - backport to 11_1_X

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7937/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7937/git-merge-result

cmsbuild · 2020-07-14T20:40:52Z

Comparison job queued.

cmsbuild · 2020-07-15T02:51:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8bb97/7937/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 55727 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780784
DQMHistoTests: Total failures: 610624
DQMHistoTests: Total nulls: 19
DQMHistoTests: Total successes: 2170091
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -6918.703 KiB( 35 files compared)
DQMHistoSizes: changed ( 1000.0,... ): -259.963 KiB DQM/TimerService
DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 1306.0,... ): -204.107 KiB DQM/TimerService
DQMHistoSizes: changed ( 1325.7,... ): -204.104 KiB DQM/TimerService
DQMHistoSizes: changed ( 136.731,... ): -204.115 KiB DQM/TimerService
DQMHistoSizes: changed ( 136.731,... ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.793 ): -0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.874 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.367 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.127 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): ...
Checked 152 log files, 16 edm output root files, 36 DQM output files

Force the definition of the USEHYBRID preprocessor symbol

16b9bcf

cmsbuild added this to the CMSSW_11_1_X milestone Jul 14, 2020

cmsbuild added backport comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jul 14, 2020

cmsbuild added bug-fix urgent labels Jul 14, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 14, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 14, 2020

cmsbuild removed the tests-approved label Jul 14, 2020

cmsbuild added tests-pending tests-started and removed tests-pending labels Jul 14, 2020

cmsbuild removed the comparison-pending label Jul 14, 2020

cmsbuild added the comparison-available label Jul 14, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 14, 2020

cmsbuild merged commit ac02ea9 into cms-sw:CMSSW_11_1_X Jul 14, 2020

cmsbuild added comparison-pending tests-rejected and removed comparison-available tests-started labels Jul 14, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 15, 2020

fwyzard deleted the Force_USEHYBRID_11_1_x branch July 28, 2020 15:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Force the definition of the USEHYBRID preprocessor symbol #30684

Force the definition of the USEHYBRID preprocessor symbol #30684

fwyzard commented Jul 14, 2020

fwyzard commented Jul 14, 2020

cmsbuild commented Jul 14, 2020 •

edited

Loading

fwyzard commented Jul 14, 2020

fwyzard commented Jul 14, 2020

rekovic commented Jul 14, 2020

cmsbuild commented Jul 14, 2020 •

edited

Loading

cmsbuild commented Jul 14, 2020

cmsbuild commented Jul 14, 2020

fwyzard commented Jul 14, 2020

cmsbuild commented Jul 14, 2020 •

edited

Loading

cmsbuild commented Jul 14, 2020

silviodonato commented Jul 14, 2020

silviodonato commented Jul 14, 2020

cmsbuild commented Jul 14, 2020

cmsbuild commented Jul 14, 2020

cmsbuild commented Jul 15, 2020

Force the definition of the USEHYBRID preprocessor symbol #30684

Force the definition of the USEHYBRID preprocessor symbol #30684

Conversation

fwyzard commented Jul 14, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

fwyzard commented Jul 14, 2020

cmsbuild commented Jul 14, 2020 • edited Loading

fwyzard commented Jul 14, 2020

fwyzard commented Jul 14, 2020

rekovic commented Jul 14, 2020

cmsbuild commented Jul 14, 2020 • edited Loading

cmsbuild commented Jul 14, 2020

cmsbuild commented Jul 14, 2020

fwyzard commented Jul 14, 2020

cmsbuild commented Jul 14, 2020 • edited Loading

cmsbuild commented Jul 14, 2020

silviodonato commented Jul 14, 2020

silviodonato commented Jul 14, 2020

cmsbuild commented Jul 14, 2020

cmsbuild commented Jul 14, 2020

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 14, 2020 •

edited

Loading

cmsbuild commented Jul 14, 2020 •

edited

Loading

cmsbuild commented Jul 14, 2020 •

edited

Loading