-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand BeamSpot Payload Inspector to account for new BeamSpotOnline Object #30647
Conversation
…bject, introduce unit test
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30647/16925
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/BeamSpotPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all, the BeamSpot Payload Inspector is expanded in order to be able to display also objects of the type
BeamSpotOnlineObjects
as introduced in PR #29662PR validation:
Relies on existing unit tests, plus the added one in this PR.
Example of output from the unit test:
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport, no backport is needed.