Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of HLT menus to 11_1_0 template (11_2_X) #30549

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Migration of HLT menus to 11_1_0 template (11_2_X)
Based on CMSSW_11_2_X_2020-07-05-2300

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30549/16781

  • This PR adds an extra 952KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Configuration

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

+1
Tested at: 64811ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01c8b9/7705/summary.html
CMSSW: CMSSW_11_2_X_2020-07-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01c8b9/7705/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787356
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2787294
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@silviodonato
Copy link
Contributor

silviodonato commented Jul 7, 2020

@Martin-Grunewald I looks like an efficiency plot disappeared (effic_dev_CMSSW_11_1_0_GRun_V11), see https://tinyurl.com/yapyuhcy. Is it expected?

@Martin-Grunewald
Copy link
Contributor Author

@silviodonato
No, it is not expected. This PR does not touch any plot generation or renames things, so it must be an unrelated (reproducubility?) issue. The backport PR jenkins does not report any changes...

@silviodonato
Copy link
Contributor

please test
in any case, I will merge this in 11_2_0_pre2. I'm just curious to understand this small difference.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: 64811ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01c8b9/7747/summary.html
CMSSW: CMSSW_11_2_X_2020-07-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01c8b9/7747/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787356
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2787300
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@missirol
Copy link
Contributor

missirol commented Jul 7, 2020

@Martin-Grunewald I looks like an efficiency plot disappeared (effic_dev_CMSSW_11_1_0_GRun_V11), see https://tinyurl.com/yapyuhcy. Is it expected?

@silviodonato

Maybe I'm missing something, but it looks like "V11" is the plot appearing post-PR, and missing pre-PR. That would be consistent with this change; if so, I guess the same should happen in the backport.
For reference, the plot is named using HLTConfigProvider::tableName, here.

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants