Add Phase2 L1T products to FEVTDEBUG EventContent #30491

rekovic · 2020-07-01T19:06:15Z

PR 11_2_X

Adding all Phase2 L1T products to FEVTDEBUG Event Content
Also add missing KBmtf in the Muon L1T sequence.

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

…n L1T sequence.

cmsbuild · 2020-07-01T19:06:42Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-01T19:12:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30491/16670

This PR adds an extra 16KB to repository

rekovic · 2020-07-01T19:14:30Z

please test

cmsbuild · 2020-07-01T19:14:52Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7572/console Started: 2020/07/01 21:18

cmsbuild · 2020-07-01T19:14:53Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1TMuon

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-07-01T20:39:45Z

-1

Tested at: 0edde4b

CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Turn on L1 track trigger in Phase2C8 and later #30479 @silviodonato: Turn on L1 track trigger in Phase2C8 and later
New Package - Phase2 L1TTrackMatch #30363 @cms-l1t-offline: New Package - Phase2 L1TTrackMatch
Move L1TrackTrigger step before L1 step #30480 @silviodonato: Move L1TrackTrigger step before L1 step

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ea7de/7572/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ea7de/7572/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ea7de/7572/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Turn on L1 track trigger in Phase2C8 and later #30479 @silviodonato: Turn on L1 track trigger in Phase2C8 and later
New Package - Phase2 L1TTrackMatch #30363 @cms-l1t-offline: New Package - Phase2 L1TTrackMatch
Move L1TrackTrigger step before L1 step #30480 @silviodonato: Move L1TrackTrigger step before L1 step

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ea7de/7572/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ea7de/7572/git-merge-result

cmsbuild · 2020-07-01T20:39:47Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

rekovic · 2020-07-01T20:49:52Z

test parameters

pull_request = Data files for Phase2 L1Trigger/L1TTrackMatch. cms-data/L1Trigger-L1TMuon#18

rekovic · 2020-07-01T20:51:16Z

failing due to missing external files for TkMuons... nothing to do with this PR.
added the externals PR in test parameters, needed only for testing.

rekovic · 2020-07-01T20:51:21Z

please test

cmsbuild · 2020-07-01T20:51:32Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/L1Trigger-L1TMuon#18

cmsbuild · 2020-07-01T22:49:02Z

-1

Tested at: 0edde4b

CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Turn on L1 track trigger in Phase2C8 and later #30479 @silviodonato: Turn on L1 track trigger in Phase2C8 and later
New Package - Phase2 L1TTrackMatch #30363 @cms-l1t-offline: New Package - Phase2 L1TTrackMatch
Move L1TrackTrigger step before L1 step #30480 @silviodonato: Move L1TrackTrigger step before L1 step

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-babe2f/7576/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-babe2f/7576/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-babe2f/7576/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Turn on L1 track trigger in Phase2C8 and later #30479 @silviodonato: Turn on L1 track trigger in Phase2C8 and later
New Package - Phase2 L1TTrackMatch #30363 @cms-l1t-offline: New Package - Phase2 L1TTrackMatch
Move L1TrackTrigger step before L1 step #30480 @silviodonato: Move L1TrackTrigger step before L1 step

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-babe2f/7576/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-babe2f/7576/git-merge-result

cmsbuild · 2020-07-01T22:49:07Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

rekovic · 2020-07-02T05:34:21Z

The reason why this one is failing is that the switching to enable in the sequence the phase2 L1T modules that depend on TrackTriggerTracks with the use of modfier phase2_trackerV14, is only present in #30482, which is not merged yet (currently failing #30482 (comment))

silviodonato · 2020-07-02T07:14:43Z

test parameters

silviodonato · 2020-07-02T07:15:27Z

please test

cmsbuild · 2020-07-02T07:15:55Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-01-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7585/console Started: 2020/07/02 09:18

cmsbuild · 2020-07-02T08:31:18Z

-1

Tested at: 0edde4b

CMSSW: CMSSW_11_2_X_2020-07-01-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ea7de/7585/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

cmsbuild · 2020-07-02T08:31:20Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

silviodonato · 2020-07-03T10:43:11Z

moved to #30498

Add Phase2 L1T products to FEVTDEBUG and add missing KBmtf in the Muo…

0edde4b

…n L1T sequence.

cmsbuild added this to the CMSSW_11_2_X milestone Jul 1, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jul 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 1, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 1, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 1, 2020

cmsbuild added comparison-pending and removed comparison-notrun tests-rejected labels Jul 1, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 1, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 1, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jul 2, 2020

cmsbuild added tests-started and removed requires-external tests-pending labels Jul 2, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 2, 2020

silviodonato mentioned this pull request Jul 2, 2020

Fix modifiers in Phase2 L1T sequences and add Phase2 L1T objects to FEVTDEBUG EventContent #30498

Merged

rekovic mentioned this pull request Jul 2, 2020

Phase2 L1 ParticleFlow #30510

Merged

cmsbuild mentioned this pull request Jul 3, 2020

Phase2 L1 NN Tau #30505

Closed

silviodonato closed this Jul 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Phase2 L1T products to FEVTDEBUG EventContent #30491

Add Phase2 L1T products to FEVTDEBUG EventContent #30491

rekovic commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

rekovic commented Jul 1, 2020

cmsbuild commented Jul 1, 2020 •

edited

Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

rekovic commented Jul 1, 2020

rekovic commented Jul 1, 2020

rekovic commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

rekovic commented Jul 2, 2020 •

edited

Loading

silviodonato commented Jul 2, 2020

silviodonato commented Jul 2, 2020

cmsbuild commented Jul 2, 2020 •

edited

Loading

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

silviodonato commented Jul 3, 2020

Add Phase2 L1T products to FEVTDEBUG EventContent #30491

Add Phase2 L1T products to FEVTDEBUG EventContent #30491

Conversation

rekovic commented Jul 1, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

rekovic commented Jul 1, 2020

cmsbuild commented Jul 1, 2020 • edited Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

rekovic commented Jul 1, 2020

rekovic commented Jul 1, 2020

rekovic commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

rekovic commented Jul 2, 2020 • edited Loading

silviodonato commented Jul 2, 2020

silviodonato commented Jul 2, 2020

cmsbuild commented Jul 2, 2020 • edited Loading

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

silviodonato commented Jul 3, 2020

cmsbuild commented Jul 1, 2020 •

edited

Loading

rekovic commented Jul 2, 2020 •

edited

Loading

cmsbuild commented Jul 2, 2020 •

edited

Loading