Phase2-hgx251 Add the algorithm for next version of HGCal geometry description #30486

bsunanda · 2020-07-01T16:14:01Z

PR description:

Add the algorithm for next version of HGCal geometry description (only DDD version is added now; DD4Hep version will be added next)

PR validation:

Tested using runTheMatrix.py. The dumped geometry using a private cfg is tested for overlaps

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2020-07-01T16:14:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-01T16:19:49Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30486/16661

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalGeometryMode.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30486/16661/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30486/16661/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-07-01T16:21:34Z

The code-checks are being triggered in jenkins.

bsunanda · 2020-07-01T16:25:23Z

@cmsbuild Please test

cmsbuild · 2020-07-01T16:25:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30486/16663

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalGeometryMode.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936

cmsbuild · 2020-07-01T16:26:12Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7565/console Started: 2020/07/01 18:31

cmsbuild · 2020-07-01T16:26:13Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-07-01T17:53:43Z

+1
Tested at: 3086c5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70acea/7565/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-01T17:53:45Z

Comparison job queued.

cmsbuild · 2020-07-01T19:38:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70acea/7565/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784069
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

cmsbuild · 2020-07-03T22:48:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70acea/7678/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784069
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

cmsbuild · 2020-07-04T03:35:31Z

+1
Tested at: 7fc0c54
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70acea/7686/summary.html
CMSSW: CMSSW_11_2_X_2020-07-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-04T03:35:33Z

Comparison job queued.

cmsbuild · 2020-07-04T14:59:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70acea/7686/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784069
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

kpedro88 · 2020-07-06T22:31:55Z

+upgrade

bsunanda · 2020-07-07T12:32:03Z

@cvuosalo @ianna Please approve this PR.

cvuosalo · 2020-07-07T15:30:30Z

Geometry/HGCalCommonData/plugins/DDHGCalEEFileAlgo.cc

+        if (u < 0)
+          copy += 10000;
+        if (v < 0)
+          copy += 100000;


When this code is migrated to DD4hep, these magic numbers (1e4, 1e5, 1e6) should be turned into constants.

cvuosalo · 2020-07-07T15:32:43Z

+1

cmsbuild · 2020-07-07T15:33:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-07T18:55:01Z

+1

Add the algorithm for next version of HGCal geometry description

ac22dbc

cmsbuild added this to the CMSSW_11_2_X milestone Jul 1, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jul 1, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 1, 2020

Code Check

3086c5f

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 1, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 1, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 3, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jul 4, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 4, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 6, 2020

cvuosalo reviewed Jul 7, 2020

View reviewed changes

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Jul 7, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 7, 2020

cmsbuild merged commit e8a0855 into cms-sw:master Jul 7, 2020

This was referenced Jul 8, 2020

Phase2-hgx252 Make the new algorithm for dd4hep #30593

Merged

Clean BuildFiles in reco plugins #30535

Merged

Use ONNXRuntime for ParticleNet inference #30599

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx251 Add the algorithm for next version of HGCal geometry description #30486

Phase2-hgx251 Add the algorithm for next version of HGCal geometry description #30486

bsunanda commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

bsunanda commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020 •

edited

Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 3, 2020

cmsbuild commented Jul 4, 2020

cmsbuild commented Jul 4, 2020

cmsbuild commented Jul 4, 2020

kpedro88 commented Jul 6, 2020

bsunanda commented Jul 7, 2020

cvuosalo Jul 7, 2020

cvuosalo commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

silviodonato commented Jul 7, 2020

Phase2-hgx251 Add the algorithm for next version of HGCal geometry description #30486

Phase2-hgx251 Add the algorithm for next version of HGCal geometry description #30486

Conversation

bsunanda commented Jul 1, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

bsunanda commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020 • edited Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 3, 2020

cmsbuild commented Jul 4, 2020

cmsbuild commented Jul 4, 2020

cmsbuild commented Jul 4, 2020

kpedro88 commented Jul 6, 2020

bsunanda commented Jul 7, 2020

cvuosalo Jul 7, 2020

Choose a reason for hiding this comment

cvuosalo commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

silviodonato commented Jul 7, 2020

cmsbuild commented Jul 1, 2020 •

edited

Loading