[HGC trigger] Clean deprecated files

[jbsauvan]

PR description:

• Remove unused old files
• Remove unused shape object in cluster class

PR validation:

Standard tests with different worflows have been run:

 runTheMatrix.py -w upgrade -l 20034.0 --maxSteps=2
 runTheMatrix.py -w upgrade -l 20434.0 --maxSteps=2
 runTheMatrix.py -w upgrade -l 22034.0 --maxSteps=2
 runTheMatrix.py -w upgrade -l 22434.0 --maxSteps=2
 runTheMatrix.py -w upgrade -l 27034.0 --maxSteps=2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30447/16585

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/L1THGCal/interface/HGCalClusterT.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

DataFormats/L1THGCal
L1Trigger/L1THGCal

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @rovere, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[kpedro88]

thanks @jbsauvan, I very much appreciate the cleanup efforts

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7497/console Started: 2020/06/29 20:30

[cmsbuild]

+1
Tested at: b1c523f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c3748/7497/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c3748/7497/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778864
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[kpedro88]

+upgrade

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1