New Package - ParticleFlow Phase2

[rekovic]

PR description:

New Package - ParticleFlow for Phase2.

Will move the data files to externals as the last step of the review. The PR will be rebased or squashed so that the data files never enter the cmssw repository history.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

L1Trigger/Phase2L1ParticleFlow/src/PuppiAlgo.cc:236:22: error: constexpr variable 'PUPPIW_0p01' must be initialized by a constant expression [clang-diagnostic-error]
  constexpr uint16_t PUPPIW_0p01 = std::round(0.01 * PFParticle::PUPPI_SCALE);
                     ^
L1Trigger/Phase2L1ParticleFlow/src/PuppiAlgo.cc:236:36: note: non-constexpr function 'round' cannot be used in a constant expression
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30256/16160

• This PR adds an extra 1288KB to repository

[cmsbuild]

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/Phase2L1ParticleFlow

The following packages do not have a category, yet:

L1Trigger/Phase2L1ParticleFlow
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7092/console Started: 2020/06/16 02:06

[cmsbuild]

-1

Tested at: 3772d46

CMSSW: CMSSW_11_2_X_2020-06-15-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b1314/7092/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency ClangBuild

• Build:

I found compilation warning when building: See details on the summary page.

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30256/16609

• This PR adds an extra 1344KB to repository

• Found files with invalid states:

  • L1Trigger/Phase2L1ParticleFlow/interface/SimpleCalibrations.h:
    • Added: 07db6c7
    • Modified: f0f47d8
    • Deleted: 414a02a
  • L1Trigger/Phase2L1ParticleFlow/plugins/L1TPFJetMetTreeProducer.cc:
    • Added: 07db6c7
    • Modified: e31d639
    • Deleted: 414a02a
  • L1Trigger/Phase2L1ParticleFlow/README.md:
    • Added: 07db6c7
    • Deleted: 414a02a

[cmsbuild]

Pull request #30256 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7508/console Started: 2020/06/30 10:25

[cmsbuild]

+1
Tested at: c47db98
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b1314/7508/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b1314/7508/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778858
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[rekovic]

+1

[rekovic]

@mrodozov
Could you please make an external directory to hold dataL1Trigger/Phase2L1ParticleFlow/data
Thanks.

[rekovic]

hold

[cmsbuild]

Pull request has been put on hold by @rekovic
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[silviodonato]

@mrodozov @smuzaffar please create the folder in cms-data/L1Trigger-Phase2L1ParticleFlow. Thank you!

[silviodonato]

@mrodozov @smuzaffar I tried to make the cms-data repository here https://github.com/cms-data/L1Trigger-Phase2L1ParticleFlow because we are in a hurry to build 11_1_0 . I hope this does not create problem (of course feel free to delete it in case of problems/mistakes)

[rekovic]

superseded by #30482