GE2/1 pads with 16 eta partitions & option to send overflow GEM clusters

[dildick]

PR description:

The GE2/1 will soon have 16 eta partitions in CMSSW to reflect the updated design. This PR defines a new pad builder for this particular geometry (not enabled yet). See also PR #29440.

Also, the GE1/1 and GE2/1 on-chamber optohybrid to off-chamber backend (CTP7/ATCA) communication protocol will have an option to send overflow clusters in the next bunch crossing. This effectively increases the bandwidth by up to a factor 2. See https://gitlab.cern.ch/tdr/notes/DN-20-016/blob/master/temp/DN-20-016_temp.pdf, page 29. This option is also not enabled yet.

EDIT: while checking the performance on Run-3 samples I noticed that a GEM copad vector was not cleared for each new event.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI @watson-ij @jshlee

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30169/15975

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TGEM/plugins/GEMPadDigiClusterProducer.cc modified in PR(s): Update valid condition for GEM pads and clusters #30115
  • File L1Trigger/L1TGEM/plugins/GEMPadDigiProducer.cc modified in PR(s): Update valid condition for GEM pads and clusters #30115

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/L1TGEM

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30169/15994

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TGEM/plugins/GEMPadDigiClusterProducer.cc modified in PR(s): Update valid condition for GEM pads and clusters #30115
  • File L1Trigger/L1TGEM/plugins/GEMPadDigiProducer.cc modified in PR(s): Update valid condition for GEM pads and clusters #30115

[cmsbuild]

Pull request #30169 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

[dildick]

Last commit is to ensure the correct pairing (roll 1, roll 2),...,(roll 15, roll 16) in GE2/1

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30169/16164

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/src/GEMCoPadProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File L1Trigger/L1TGEM/plugins/GEMPadDigiClusterProducer.cc modified in PR(s): Update valid condition for GEM pads and clusters #30115
  • File L1Trigger/L1TGEM/plugins/GEMPadDigiProducer.cc modified in PR(s): Update valid condition for GEM pads and clusters #30115

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30169/16164/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30169/16164/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-18-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7186/console Started: 2020/06/18 19:11

[cmsbuild]

+1
Tested at: 386e52e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f28ca7/7186/summary.html
CMSSW: CMSSW_11_2_X_2020-06-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f28ca7/7186/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 24
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778737
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[dildick]

A few failures in the comparisons. They are expected.

Previously, a container in the GEMCoPadProcessor was not cleared in each event, so coincidence pads would incorrectly get duplicated in the sample. In WF 20434.0 one can see the result of the fix. In 10 ttbar events without pileup, there shouldn't too many coincidence pads. In this test, there were just 2, but previously they would get copied 7 times over (first coincidence pads appearing in the second event).

[dildick]

@rekovic Do you have any further comments?

[dildick]

@rekovic Can you sign this PR? There is bug fix needs to be incorporated. Thanks.

[silviodonato]

@rekovic, can you please check and eventually sign?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[rekovic]

@dildick
Please make a backport of this PR and of #30564 to 11_1_X. These known development/fix should be included in the 11_1_0_patch to be used to process L1T for HLT TDR. Thanks.