-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLT]Replaced boost::tuple for std::tuple #29939
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29939/15567
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
16e5b4b
to
0674b03
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29939/15568
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: HLTriggerOffline/Muon @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@camolezi we don't have you identified as HLT Muon developer(?) in |
@jfernan2 |
please test |
The tests are being triggered in jenkins. |
just to clarify - @camolezi is not a HLT muon validation developer. He is looking at boost dependencies that are now in the c++ standard library. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Replaced boost::tuple for std::tuple. They have similar functionality and std::tuple should reduce boost dependencies.
PR validation:
Passed on basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6